Add CRC32C (Castagnoli) checksum via XrdOucCRC::Calc32C#66
Open
jthiltges wants to merge 6 commits into
Open
Conversation
Co-authored-by: djw8605 <79268+djw8605@users.noreply.github.com>
Co-authored-by: djw8605 <79268+djw8605@users.noreply.github.com>
Co-authored-by: djw8605 <79268+djw8605@users.noreply.github.com>
Co-authored-by: djw8605 <79268+djw8605@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds CRC32C checksum support using XRootD’s XrdOucCRC::Calc32C, integrating it into checksum calculation, storage, and configuration parsing.
Changes:
- Adds
CRC32Cas a checksum type and stores CRC32C state inChecksumState. - Calculates and returns CRC32C values alongside existing checksum algorithms.
- Allows
crc32cinxrootd.chksumconfiguration. - Adds
build/to.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/XrdChecksumCalc.cc |
Adds CRC32C state initialization, update, and hex output. |
src/XrdChecksum.hh |
Adds CRC32C enum value and state field. |
src/XrdChecksum.cc |
Adds CRC32C persistence and request handling. |
src/MultiuserFileSystem.cc |
Parses crc32c from checksum configuration. |
.gitignore |
Ignores local build directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+79
to
+81
| else if (!strncasecmp(Cks.Name, "crc32c", Cks.NameSize)) | ||
| { | ||
| return_digest = ChecksumManager::CRC32C; |
Member
|
@copilot apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from #63, switching to XrdOucCRC::Calc32C for checksum calculation.