Skip to content

Bump github.com/onsi/ginkgo/v2 from 2.28.3 to 2.29.0#514

Merged
github-actions[bot] merged 1 commit into
masterfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.29.0
May 20, 2026
Merged

Bump github.com/onsi/ginkgo/v2 from 2.28.3 to 2.29.0#514
github-actions[bot] merged 1 commit into
masterfrom
dependabot/go_modules/github.com/onsi/ginkgo/v2-2.29.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 20, 2026

Bumps github.com/onsi/ginkgo/v2 from 2.28.3 to 2.29.0.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.29.0

2.29.0

GinkgoHelperGo makes it easier to write test helpers that need to run in goroutines. Specifically, it makes managing the failure state and capturing failure panics correctly straightforward.

ginkgo outline now includes entries defined in DescribeTableSubtree

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.29.0

GinkgoHelperGo makes it easier to write test helpers that need to run in goroutines. Specifically, it makes managing the failure state and capturing failure panics correctly straightforward.

ginkgo outline now includes entries defined in DescribeTableSubtree

Commits
  • 04b5bcb v2.29.0
  • 124232a docs: GinkgoHelperGo
  • ad9cee8 feat: GinkgoHelperGo, with integration tests
  • 9e56a0a chore: refactor devcontainer for better maintenance
  • 3d235a9 chore: ignore internal/tmp_*/ integration suite temporary dirs
  • 782666a feat: devcontainer configuration with local pkgsite and GH pages
  • 009dd04 Support DescribeTableSubtree in ginkgo outline
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Chores
    • Updated test framework dependency to the latest version for improved stability and testing capabilities.

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.28.3 to 2.29.0.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.28.3...v2.29.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-version: 2.29.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 20, 2026
@github-actions github-actions Bot enabled auto-merge (squash) May 20, 2026 23:16
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a188c0cd-e3c7-4c53-941b-dcf2e95377c9

📥 Commits

Reviewing files that changed from the base of the PR and between 177c525 and 521259a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Walkthrough

This PR updates the Go module dependency for the Ginkgo v2 test framework from version 2.28.3 to 2.29.0 in go.mod. This is a patch-level version bump with no changes to source code or module requirements other than the single dependency version update.

Changes

Ginkgo Test Framework Update

Layer / File(s) Summary
Ginkgo v2 version update
go.mod
The github.com/onsi/ginkgo/v2 dependency is updated from v2.28.3 to v2.29.0, a patch-level version bump.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • bmeng
  • xiaoyu74
🚥 Pre-merge checks | ✅ 9 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Found 43 assertions without meaningful messages and multiple tests with unrelated behaviors in single It blocks violating single responsibility principle. Add descriptive failure messages to all Expect assertions. Split multi-behavior tests (line 239 tests 3 user scenarios; line 252 tests ServiceAccount + pod ops) into separate focused It blocks.
Microshift Test Compatibility ⚠️ Warning New Ginkgo e2e tests reference unsupported MicroShift APIs (FeatureGate, ClusterVersion) without MicroShift skip guards. Add [apigroup:config.openshift.io] tags or [Skipped:MicroShift] labels to tests using FeatureGate and ClusterVersion APIs.
Single Node Openshift (Sno) Test Compatibility ⚠️ Warning New tests in test/e2e/validation_webhook_tests.go assume multi-node clusters: DaemonSet replication, separate master/infra nodes, and infra node existence, all of which will fail on SNO. Add [Skipped:SingleReplicaTopology] labels to "exists and is running", pod scheduling tests, and "blocks modifications to nodes", or wrap with SNO detection and skip.
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and accurately summarizes the main change: bumping the ginkgo/v2 dependency from version 2.28.3 to 2.29.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All Ginkgo test names in the e2e test file are stable and deterministic with descriptive, static titles. No dynamic content in test names; dynamic values correctly used only in test bodies.
Topology-Aware Scheduling Compatibility ✅ Passed PR only bumps Ginkgo testing framework from v2.28.3 to v2.29.0 in go.mod. No deployment manifests, controllers, or scheduling constraints are modified.
Ote Binary Stdout Contract ✅ Passed Ginkgo v2.29.0 doesn't violate OTE stdout contract. Suite uses GinkgoLogr, JUnit output to file, no process-level stdout writes detected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only bumps the ginkgo/v2 dependency (v2.28.3 → v2.29.0); no new tests were added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dependabot/go_modules/github.com/onsi/ginkgo/v2-2.29.0

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign xiaoyu74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 20, 2026

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions Bot merged commit cc06370 into master May 20, 2026
3 of 10 checks passed
@dependabot dependabot Bot deleted the dependabot/go_modules/github.com/onsi/ginkgo/v2-2.29.0 branch May 20, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants