Consume common templates via CommonTemplates field#1119
Conversation
Remove duplicated templates from the operator and consume them from lib-common via the CommonTemplates field. This allows maintaining common configuration files (e.g. ssl.conf) in a single location across all operators. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4d37539
into
openstack-k8s-operators:main
|
sharing the ssl.conf may make sense but the httpd config tends to be at least partly service specific nova has 2 rest apis for example and neither can run with multiple threads they have to be scaled by process or replicas. the most obvious delta is the path to the wsgi module is service dependent This commit seam ok to me but also i don't really see the maintenance of these files being worth the added complexity of now needing the go to lib common to understand how that is deployed. |
Thanks for the comment, @SeanMooney. Deduplicating common configurations (e.g., |
The
ssl.confhttpdconfiguration is duplicated across service operators.This patch removes the local copy and consumes it from lib-common.
Jira: OSPRH-30239