Skip to content

Consume common templates via CommonTemplates field#378

Open
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates
Open

Consume common templates via CommonTemplates field#378
fmount wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fmount:templates

Conversation

@fmount
Copy link
Copy Markdown
Contributor

@fmount fmount commented May 18, 2026 •
edited
Loading

The ssl.conf httpd configuration is duplicated across service operators.
This patch removes the local copy and consumes it from lib-common.

Jira: OSPRH-30239

@fmount fmount requested review from abays, amoralej and stuggi May 18, 2026 15:12
@openshift-ci openshift-ci Bot requested a review from dprince May 18, 2026 15:12
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign seanmooney for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 18, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/5b0ec9c0c6624c1795b437c254c91a60

✔️ openstack-meta-content-provider-master SUCCESS in 3h 14m 37s
❌ watcher-operator-validation-master FAILURE in 2h 16m 45s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 56m 53s
❌ watcher-operator-validation-epoxy FAILURE in 1h 50m 09s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 2h 00m 55s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 57m 26s

@fmount
Consume common templates via CommonTemplates field
d8764a7 
Remove duplicated templates from the operator and consume them
from lib-common via the CommonTemplates field. This allows
maintaining common configuration files (e.g. ssl.conf) in a
single location across all operators.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@fmount
Copy link
Copy Markdown
Contributor Author

fmount commented May 19, 2026

recheck

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 19, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/9ca4eb3242cf4bc2adb0e81688a95135

✔️ openstack-meta-content-provider-master SUCCESS in 2h 46m 45s
❌ watcher-operator-validation-master FAILURE in 1h 42m 57s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 54m 32s
❌ watcher-operator-validation-epoxy POST_FAILURE in 1h 50m 11s
✔️ watcher-operator-validation-epoxy-ocp4-18 SUCCESS in 1h 58m 54s
✔️ noop SUCCESS in 0s
❌ watcher-operator-kuttl FAILURE in 1h 23m 50s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays Awaiting requested review from abays

@amoralej amoralej Awaiting requested review from amoralej

@stuggi stuggi Awaiting requested review from stuggi

@dprince dprince Awaiting requested review from dprince

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fmount