Skip to content

feat: validate package availability before queuing builds#1630

Open
aparcar wants to merge 1 commit intoopenwrt:mainfrom
aparcar:validate_packages
Open

feat: validate package availability before queuing builds#1630
aparcar wants to merge 1 commit intoopenwrt:mainfrom
aparcar:validate_packages

Conversation

@aparcar
Copy link
Copy Markdown
Member

@aparcar aparcar commented May 3, 2026

Adds an opt-in validate_packages setting that rejects build requests naming packages not present in the upstream index or in any user-supplied repository, avoiding the cost of a full ImageBuilder run for typos and dropped packages. Sets are cached in Redis (24h for releases, 15m for snapshots and user repos). Apk repos pointing at packages.adb resolve to the sibling index.json. Off by default; intended for the main server.

Adds an opt-in `validate_packages` setting that rejects build requests
naming packages not present in the upstream index or in any user-supplied
repository, avoiding the cost of a full ImageBuilder run for typos and
dropped packages. Sets are cached in Redis (24h for releases, 15m for
snapshots and user repos). Apk repos pointing at packages.adb resolve to
the sibling index.json. Off by default; intended for the main server.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Paul Spooren <mail@aparcar.org>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

❌ Patch coverage is 92.50000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.47%. Comparing base (5e65dec) to head (16ba39c).
⚠️ Report is 395 commits behind head on main.

Files with missing lines Patch % Lines
asu/util.py 87.17% 5 Missing ⚠️
asu/routers/api.py 88.00% 3 Missing ⚠️
asu/repositories.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1630       +/-   ##
===========================================
+ Coverage   80.75%   91.47%   +10.71%     
===========================================
  Files          15       20        +5     
  Lines         977     2204     +1227     
===========================================
+ Hits          789     2016     +1227     
  Misses        188      188               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant