[AI-FSSDK] [FSSDK-12369] Add local holdouts support#628
Open
Mat001 wants to merge 3 commits into
Open
Conversation
jaeopt
approved these changes
May 19, 2026
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
LGTM - a couple of comments to confirm
jaeopt
requested changes
May 19, 2026
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Found ForcedDecision repeated 2 times for each rule.
… in DecisionService Move validatedForcedDecision and localHoldout checks from getVariationFromExperiment and getVariationForFeatureInRollout into getVariationFromExperimentRule and getVariationFromDeliveryRule, eliminating redundant evaluation. Extract shared local holdout logic into evaluateLocalHoldouts() and add unit tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add a local holdout with includedRules to the JSON fixture and expected config so Json, Gson, Jackson, and JsonSimple parsers all verify local holdout parsing. Also add includedRules/isGlobal assertions to verifyHoldouts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds local holdouts support to the Java SDK.
Jira ticket: FSSDK-12369
Changes
Test plan
🤖 Generated with Claude Code via AI-FSSDK