Merged
Conversation
ParameterSource
c8306cf to
1f42ba5
Compare
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
Mar 5, 2026
d7d41bb to
d44d711
Compare
Collaborator
Author
|
This PR will need its documentation rewritten from rST to Markdown if #3259 is merged. |
davidism
approved these changes
Apr 13, 2026
Collaborator
Author
|
I intentionally keep this PR in unmergeable state as I am waiting for #3259 to be merge beforehand. |
d44d711 to
4d0a4dd
Compare
4d0a4dd to
ac5cec5
Compare
Collaborator
Author
|
Now that #3259 has been translated from rST to MyST, I was able to fix the merge conflict. This PR is ready to be merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorder the
ParameterSourceenum by precedence, as suggested in #2879.It brings an interesting property of being able to check if a value was explicitly provided with that kind of code:
Additionally, this PR:
EnumtoIntEnumParameterSourceto the package root