Octo 11470#369
Merged
Merged
Conversation
Contributor
Author
|
Note: |
lorandvarga
approved these changes
Apr 29, 2026
lorandvarga
requested changes
Apr 29, 2026
Collaborator
lorandvarga
left a comment
lorandvarga
left a comment
There was a problem hiding this comment.
Make sure we don't commit proprietary information.
scripts never produce; now grep metrics from report markdown directly
- Fix DFXP extraction bugs: wrong ERE alternation, incorrect value from
shared footer line, broken shell precedence in fallback
- Pin archive/github-actions-slack to commit SHA for supply-chain safety
- Replace grep -oP (Perl-only) with portable grep -oE
- Sanitize pr_summary.txt ingestion with allowlist-only key extraction
- Fix Python version inconsistency (3.x -> 3.11) in all_compliance_checks
- Fix incorrect RU4 suggestion: 94a7 is correct per CEA-608 odd parity
- Normalize skill filenames (SKILL.md -> skill.md) + update all references
- Restore docs/conf.py version to 2.2.21 (merge regression)
- Update skills README with security section and report clarifications
lorandvarga
previously approved these changes
Apr 30, 2026
reports warn when classes/functions have been renamed or moved - Add gotchas #10 (SHA-pinning + permissions), #11 (Slack crash guard), #12 (fork PR write failures) - Expand gotcha #4 with attacker-controlled context value guidance - Add SCRIPT_CRASHED guard to Slack success notifications in SCC, VTT, and DFXP workflows (gotcha #11) - Add continue-on-error to PR comment step for fork safety (gotcha #12) - Fix IMPL regex in suggest-dfxp-fixes and suggest-scc-fixes to use unified pattern IMPL-(?:[A-Z]+-)?\d{3} (gotcha #7) - Add pre-flight and post-run gotcha instructions to all suggest-* and analyze-* skills - Fix set -e exit capture in run-all-compliance (gotcha #5) - Fix source attribution in analyze-scc-docs (gotcha #2) - Add frontmatter to run-all-compliance skill - Update README with security notes and expanded gotchas summary
lorandvarga
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Claude Code compliance skills, CI workflows, and spec documentation
What's included
12 Claude Code skills** (
.claude/skills/):analyze-{scc,vtt,dfxp}-docs— generate spec summaries from public sourcescheck-{scc,vtt,dfxp}-compliance— deep validation with 235+ rules and 621 control codessuggest-{scc,vtt,dfxp}-fixes— analyze compliance reports, generate targeted code fixesrun-all-compliance— run all 3 checks in sequencecheck-last-pr— PR-level compliance review with regression detection6 GitHub Actions workflows** (
.github/workflows/):pull_requestandworkflow_dispatch, comments on PRSpec documentation** (
ai_artifacts/specs/):ai_artifacts/compliance_checks/)