Add backup transactions validation for pre-signed ephemeral transactions#1146
Merged
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sharqiewicz
reviewed
May 14, 2026
Sharqiewicz
reviewed
May 14, 2026
| }); | ||
| } | ||
|
|
||
| const backupNonces = Object.values(additionalTxs) |
Member
There was a problem hiding this comment.
What do you think about
const actualNonces = Object.values(additionalTxs).map(b => b.nonce).sort((a, b) => a - b);
const expectedNonces = Array.from({ length: EXPECTED_BACKUP_COUNT }, (_, i) => tx.nonce + 1 + i);
if (!actualNonces.every((n, i) => n === expectedNonces[i])) {
throw new APIError({
message: `Transaction for phase ${tx.phase} has invalid backup nonce sequence. Expected ${expectedNonces.join(",")}, got
${actualNonces.join(",")}`,
status: httpStatus.BAD_REQUEST
});
}
Sharqiewicz
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds server-side validation to ensure ephemeral-signed presigned transactions include the expected set of backup transactions (count + nonce sequencing), and introduces additional balance-settlement checks/delays in EVM-related phases to reduce race conditions between phases.
Changes:
- Centralized
NUMBER_OF_PRESIGNED_TXSinto@vortexfi/sharedconstants and updated call sites. - Added API validation enforcing presence of backup transactions in
meta.additionalTxsand sequential backup nonces for ephemeral signers. - Added EVM balance waiting/checks in squid/nabla/subsidy phase handlers to avoid proceeding before funds are visible on-chain.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/helpers/signUnsigned.ts | Uses shared NUMBER_OF_PRESIGNED_TXS constant instead of a local magic number. |
| packages/shared/src/constants.ts | Introduces NUMBER_OF_PRESIGNED_TXS as a shared exported constant. |
| apps/api/src/api/services/transactions/validation.ts | Adds validateBackupTransactions and enforces it during presigned tx validation. |
| apps/api/src/api/services/transactions/validation.test.ts | Updates fixtures to include backup txs and adds negative tests for missing/invalid backups. |
| apps/api/src/api/services/transactions/stellar/offrampTransaction.ts | Switches to shared NUMBER_OF_PRESIGNED_TXS constant. |
| apps/api/src/api/services/phases/handlers/subsidize-post-swap-evm-handler.ts | Adds a fixed delay before checking EVM balances. |
| apps/api/src/api/services/phases/handlers/squid-router-phase-handler.ts | Adds a pre-swap EVM balance check based on quote bridge metadata. |
| apps/api/src/api/services/phases/handlers/nabla-swap-handler.ts | Adds a pre-swap EVM balance check for the input token on Base. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+64
to
+65
| await new Promise(resolve => setTimeout(resolve, 15000)); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Accept the inefficiency for now.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…nto validate-backups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Adds a validation check to ensure any ephemeral-signed transaction has the required number of backup transactions, with the right nonce sequence.
Note: it does NOT validate the correctness of the data itself.
Additional fixes
Adds delays before checking balances in subsidy phases. This ensure the balance from a previous
distributeFeephase is properly settled.