build: fix the configure.ac USDT check for armhf platform#2595
build: fix the configure.ac USDT check for armhf platform#2595natoscott wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR updates USDT (Userland Statically Defined Tracing) static probes detection in the PCP build configuration. The ChangesUSDT Probes ARM Target Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@debian/changelog`:
- Line 4: The changelog entry currently says "Fix the configure.ac USDT check
for armhf platform (closes: `#1133063`)"; update it to avoid incorrectly closing
an already-closed bug by either (a) removing "closes: `#1133063`" and leaving "Fix
the configure.ac USDT check for armhf platform", (b) changing to phrasing such
as "Further fix for `#1133063`" if this is a follow-up, or (c) verifying that the
referenced bug number is correct and replacing it with the proper (reopened or
different) bug number; ensure the final text no longer claims to close `#1133063`
unless that bug was explicitly reopened.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d5a70f04-6856-40f0-9917-6672c8c5d193
📒 Files selected for processing (3)
configureconfigure.acdebian/changelog
Ensure the target_cpu now injected through the correction to configure.ac handling in Debian builds (via commit 704b93c) matches with what configure.ac USDT check is looking for. Resolves Debian bug #1133063
Ensure the target_cpu now injected through the correction to configure.ac handling in Debian builds (via commit 704b93c) matches with what configure.ac USDT check is looking for.
Resolves Debian bug #1133063
Summary by CodeRabbit