Skip to content

build: fix the configure.ac USDT check for armhf platform#2595

Open
natoscott wants to merge 1 commit into
performancecopilot:mainfrom
natoscott:deb-arm-build
Open

build: fix the configure.ac USDT check for armhf platform#2595
natoscott wants to merge 1 commit into
performancecopilot:mainfrom
natoscott:deb-arm-build

Conversation

@natoscott
Copy link
Copy Markdown
Member

@natoscott natoscott commented May 19, 2026

Ensure the target_cpu now injected through the correction to configure.ac handling in Debian builds (via commit 704b93c) matches with what configure.ac USDT check is looking for.

Resolves Debian bug #1133063

Summary by CodeRabbit

  • Bug Fixes
    • Fixed detection of static USDT probes on ARM platforms, restoring/enabling USDT support on ARM-based systems (including armhf).
    • This improves performance monitoring and tracing reliability on affected ARM deployments.

Review Change Stack

@natoscott natoscott requested a review from kmcdonell May 19, 2026 05:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e9d128b7-4b9c-4d30-bcf2-7711f39642e6

📥 Commits

Reviewing files that changed from the base of the PR and between 0bf50cd and ada59a5.

📒 Files selected for processing (3)
  • configure
  • configure.ac
  • debian/changelog
✅ Files skipped from review due to trivial changes (1)
  • debian/changelog
🚧 Files skipped from review as they are similar to previous changes (2)
  • configure.ac
  • configure

📝 Walkthrough

Walkthrough

The PR updates USDT (Userland Statically Defined Tracing) static probes detection in the PCP build configuration. The target_cpu condition that gates HAVE_STATIC_PROBES is changed from matching armv8l to arm, updating both the configure.ac source and generated configure script, with a changelog entry documenting the fix for armhf platform.

Changes

USDT Probes ARM Target Fix

Layer / File(s) Summary
USDT probes ARM target condition
configure.ac, configure, debian/changelog
The target_cpu check controlling static probes support is updated from armv8l to arm in the source configuration and generated script, with changelog documentation of the armhf platform fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops 'cross ARM machines,
With probes now set to wiser scenes—
From armv8l to arm so true,
The static tracing's born anew! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the USDT check in configure.ac for the armhf platform by replacing the armv8l check with an arm check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@debian/changelog`:
- Line 4: The changelog entry currently says "Fix the configure.ac USDT check
for armhf platform (closes: `#1133063`)"; update it to avoid incorrectly closing
an already-closed bug by either (a) removing "closes: `#1133063`" and leaving "Fix
the configure.ac USDT check for armhf platform", (b) changing to phrasing such
as "Further fix for `#1133063`" if this is a follow-up, or (c) verifying that the
referenced bug number is correct and replacing it with the proper (reopened or
different) bug number; ensure the final text no longer claims to close `#1133063`
unless that bug was explicitly reopened.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d5a70f04-6856-40f0-9917-6672c8c5d193

📥 Commits

Reviewing files that changed from the base of the PR and between 1f4bcc3 and 0bf50cd.

📒 Files selected for processing (3)
  • configure
  • configure.ac
  • debian/changelog

Comment thread debian/changelog Outdated
Ensure the target_cpu now injected through the correction to
configure.ac handling in Debian builds (via commit 704b93c)
matches with what configure.ac USDT check is looking for.

Resolves Debian bug #1133063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant