Skip to content

Commit c3052fb

Browse files
committed
fix: flakey firefox extension tests
1 parent 926bd3d commit c3052fb

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

src/utils/ExtensionLoader.js

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ define(function (require, exports, module) {
542542
console.log("Loading Extension Test from virtual fs: ", extConfig);
543543
_testExtensionByURL(extensionName, extConfig, 'unittests').always(function () {
544544
// Always resolve the promise even if some extensions had errors
545-
console.log("lc", extensionName);
545+
console.log("tested", extensionName);
546546
loadResult.resolve();
547547
});
548548
return loadResult.promise();
@@ -571,19 +571,27 @@ define(function (require, exports, module) {
571571
const srcBaseUrl = new URL(baseUrl + '/../src').href;
572572
var result = new $.Deferred();
573573

574-
for (let extensionEntry of DefaultExtensionsList){
575-
console.log("Testing default extension: ", extensionEntry);
576-
var extConfig = {
574+
Async.doInParallel(DefaultExtensionsList, function (extensionEntry) {
575+
const loadResult = new $.Deferred();
576+
const extConfig = {
577577
basePath: 'extensions/default',
578578
baseUrl: new URL(srcBaseUrl + DEFAULT_EXTENSIONS_PATH_BASE + "/" + extensionEntry).href,
579579
paths: {
580580
"perf": bracketsPath + "/perf",
581581
"spec": bracketsPath + "/spec"
582582
}
583583
};
584-
_testExtensionByURL(extensionEntry, extConfig, 'unittests');
585-
}
586-
result.resolve();
584+
console.log("Testing default extension: ", extensionEntry);
585+
_testExtensionByURL(extensionEntry, extConfig, 'unittests').always(function () {
586+
// Always resolve the promise even if some extensions had errors
587+
console.log("load complete", extensionEntry);
588+
loadResult.resolve();
589+
});
590+
return loadResult.promise();
591+
}).always(function () {
592+
// Always resolve the promise even if some extensions had errors
593+
result.resolve();
594+
});
587595

588596
return result.promise();
589597
}

0 commit comments

Comments
 (0)