Skip to content

pdo_dblib: Do not reuse dead connections #21681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freddy77 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

pdo_dblib: Do not reuse dead connections #21681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ext/pdo_dblib/dblib_driver.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,16 @@ static int dblib_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_valu
return 1;
}

static zend_result dblib_handle_check_liveness(pdo_dbh_t *dbh)
{
pdo_dblib_db_handle *H = (pdo_dblib_db_handle *)dbh->driver_data;

if (dbdead(H->link))
return FAILURE;

return SUCCESS;
}

static const struct pdo_dbh_methods dblib_methods = {
dblib_handle_closer,
dblib_handle_preparer,
Expand All @@ -434,7 +444,7 @@ static const struct pdo_dbh_methods dblib_methods = {
dblib_handle_last_id, /* last insert id */
dblib_fetch_error, /* fetch error */
dblib_get_attribute, /* get attr */
NULL, /* check liveness */
dblib_handle_check_liveness, /* check_liveness */
NULL, /* get driver methods */
NULL, /* request shutdown */
NULL, /* in transaction, use PDO's internal tracking mechanism */
Expand Down
Loading