Include file path and line number in parse error messages#740
Open
lacatoire wants to merge 1 commit intophpDocumentor:7.xfrom
Open
Include file path and line number in parse error messages#740lacatoire wants to merge 1 commit intophpDocumentor:7.xfrom
lacatoire wants to merge 1 commit intophpDocumentor:7.xfrom
Conversation
When NodesFactory encounters a PhpParser\Error, catch it and re-throw a phpDocumentor\Reflection\Exception that includes the source file path and line number. This gives consumers actionable error context instead of raw php-parser internals. The create() method now accepts an optional $filePath parameter, and Factory\File passes the source path automatically.
jaapio
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When parsing a PHP file fails, the error now includes the source file path and line number instead of raw php-parser internals.
Before:
After:
NodesFactory::create()accepts an optional$filePathparameterPhpParser\Errorand re-throws asphpDocumentor\Reflection\Exceptionwith file + line contextFactory\Filepasses the source path automatically$previousfor debuggingSuggested in phpDocumentor/phpDocumentor#4088 (comment) — moving the error enrichment into the reflection library so all consumers benefit.