Remove deprecated curl_close

williamdes · williamdes · commit a04c6054fc8f · 2026-02-16T11:50:20.000+01:00
diff --git a/src/Controller/Component/GithubApiComponent.php b/src/Controller/Component/GithubApiComponent.php
@@ -24,7 +24,6 @@
 use Cake\Routing\Router;
 
 use function array_merge;
-use function curl_close;
 use function curl_error;
 use function curl_init;
 use function curl_setopt;
@@ -159,7 +158,6 @@ public function sendRequest(
         $response = curl_exec($curlHandle);// phpcs:ignore SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFallbackGlobalName
         if ($response === false) {
             Log::error('Curl error: "' . curl_error($curlHandle) . '" for: ' . $url);
-            curl_close($curlHandle);
 
             return ['', 0];
         }
@@ -177,8 +175,6 @@ public function sendRequest(
             ];
         }
 
-        curl_close($curlHandle);
-
         return $decodedResponse;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`use Cake\Routing\Router;`
`25`	`25`
`26`	`26`	`use function array_merge;`
`27`		`-use function curl_close;`
`28`	`27`	`use function curl_error;`
`29`	`28`	`use function curl_init;`
`30`	`29`	`use function curl_setopt;`
`@@ -159,7 +158,6 @@ public function sendRequest(`
`159`	`158`	`$response = curl_exec($curlHandle);// phpcs:ignore SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFallbackGlobalName`
`160`	`159`	`if ($response === false) {`
`161`	`160`	`Log::error('Curl error: "' . curl_error($curlHandle) . '" for: ' . $url);`
`162`		`- curl_close($curlHandle);`
`163`	`161`
`164`	`162`	`return ['', 0];`
`165`	`163`	`}`
`@@ -177,8 +175,6 @@ public function sendRequest(`
`177`	`175`	`];`
`178`	`176`	`}`
`179`	`177`
`180`		`- curl_close($curlHandle);`
`181`		`-`
`182`	`178`	`return $decodedResponse;`
`183`	`179`	`}`
`184`	`180`