Skip to content

Commit 3d69016

Browse files
committed
Don't try to use milestoneMap on different repos
1 parent 33b8f36 commit 3d69016

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

src/githubHelper.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,7 +1209,7 @@ export class GithubHelper {
12091209
return `[${milestone.title}](${repoLink}/milestone/${milestone.number})`;
12101210
}
12111211
console.log(
1212-
`\tERROR: Milestone ${number}, "${title}" not found among migrated milestones.`
1212+
`\tMilestone '${number || title}' not found in milestone map.`
12131213
);
12141214
return `'Reference to deleted milestone ${number || title}'`;
12151215
};
@@ -1220,15 +1220,18 @@ export class GithubHelper {
12201220
'(' +
12211221
Object.keys(settings.projectmap).join(')%(".*?")|(') +
12221222
')%(".*?")';
1223-
str = str.replace(new RegExp(reString, 'g'), (_, p1, p2) =>
1224-
milestoneReplacer('', p2, settings.projectmap[p1])
1223+
str = str.replace(
1224+
new RegExp(reString, 'g'),
1225+
(_, p1, p2) => `Milestone ${p2} in ${settings.projectmap[p1]}`
12251226
);
12261227

12271228
// Replace: project%nn
12281229
reString =
12291230
'(' + Object.keys(settings.projectmap).join(')%(\\d+)|(') + ')%(\\d+)';
1230-
str = str.replace(new RegExp(reString, 'g'), (_, p1, p2) =>
1231-
milestoneReplacer(p2, '', settings.projectmap[p1])
1231+
str = str.replace(
1232+
new RegExp(reString, 'g'),
1233+
(_, p1, p2) =>
1234+
`[Milestone ${p2} in ${settings.projectmap[p1]}](${this.githubUrl}/${this.githubOwner}/${settings.projectmap[p1]})`
12321235
);
12331236
}
12341237
// Replace: %"Milestone"

0 commit comments

Comments
 (0)