This repository was archived by the owner on Mar 11, 2020. It is now read-only.
Conversation
|
Deploy preview for postpost-storybook ready! Built with commit f96b27c |
b0g3r
reviewed
Mar 9, 2019
b0g3r
reviewed
Mar 10, 2019
|
|
||
| Sentry.init({ | ||
| dsn: process.env.SENTRY_DSN, | ||
| environment: process.env.SENTRY_ENVIRONMENT, |
Member
There was a problem hiding this comment.
Я бы всё таки вынес environment в .env.development и .env.production, чтобы случайно не придумать чего-то лишнего
Member
Author
There was a problem hiding this comment.
Не очень понял о чем ты конкретно
Member
There was a problem hiding this comment.
SENTRY_ENVIRONMENT не меняется от комьютера к компьютеру, поэтому его можно вынести в
.env.production и .env.development
Member
There was a problem hiding this comment.
либо можно вообще использовать здесь process.env.NODE_ENV, как тебе такое?
Member
|
Если уже настраивал автосборку с учётом сентри — то обрати внимание, я создал два проекта в сентри, один для фронта, другой для бекенда |
Member
Author
|
@b0g3r пинг 😘 |
b0g3r
reviewed
Mar 16, 2019
| - export IMAGE_TAG=`if [ "$TRAVIS_BRANCH" == "master" ]; then echo "latest"; else echo "dev"; fi` | ||
| - export IMAGE_NAME="piterpy/postpost-frontend" | ||
| - docker build -t $IMAGE_NAME:$IMAGE_TAG . | ||
| - docker build -e SENTRY_DSN=$SENTRY_DSN -e SENTRY_ENVIRONMENT=develop -t $IMAGE_NAME:$IMAGE_TAG . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24