Fix Lint: allow lowercase and special chars in REQUEST_METHOD#726
Draft
kimjune01 wants to merge 1 commit into
Draft
Fix Lint: allow lowercase and special chars in REQUEST_METHOD#726kimjune01 wants to merge 1 commit into
kimjune01 wants to merge 1 commit into
Conversation
Middleware::Lint was incorrectly rejecting valid HTTP method tokens that contained lowercase letters or special characters. RFC 7231 section 4.1 defines method tokens as case-sensitive sequences of tchar (RFC 7230 section 3.2.6), which includes A-Z, a-z, 0-9, and !#$%&'*+-.^_`|~. This fix updates the REQUEST_METHOD validation regex to accept all valid tchar sequences, allowing methods like "get", "GeT", and "my-custom-method". Fixes plack#588
Author
|
PR lacks a test exercising the change, so drafting. Please close or take it over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REQUEST_METHODvalidation regex from/^[A-Z]+$/to RFC 9110 tchar to accept lowercase methods, digits, and other valid token charactersFixes #588
Test plan
prove -Ilib t/Plack-Middleware/lint_env.tpasses (12/12 tests)get), mixed case (myMethod), hyphenated (X-Custom), and empty string (rejected)