Add bounds checks for label positioning in Sankey diagram#2830
Open
amedeorizzo wants to merge 2 commits intoplouc:masterfrom
Open
Add bounds checks for label positioning in Sankey diagram#2830amedeorizzo wants to merge 2 commits intoplouc:masterfrom
amedeorizzo wants to merge 2 commits intoplouc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopened from closed stale PR #2786
Implement bounds checks to prevent extreme x values when positioning labels in the Sankey diagram.
The extreme x values happened on certain width values of the chart rect (890, 899, 908, 922 and other width values): the right labels of the sankey got an x translate value of over 8k. Resizing the chart by only one pixel fixed the x translate value.