-
Notifications
You must be signed in to change notification settings - Fork 661
feat: implement ADR-023 Part 1 #7724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
abfe9c4
feat(ActionBar): add data-component attributes for better accessibility
francinelucca 6381280
fix test
francinelucca 091de76
Merge branch 'main' of github.com:primer/react into chore/implement-a…
francinelucca 32d4062
fix(ActionBar): update data-component attributes for IconButton and Menu
francinelucca c7c0da7
Add data-component for ActionList
francinelucca 4cf2494
fix(ActionList): add data-component attributes for Item and LinkItem
francinelucca 2962363
test(Tooltip): add tests for data-component attributes in Tooltip and…
francinelucca 3f92c21
Merge branch 'main' of github.com:primer/react into chore/implement-a…
francinelucca 273f681
fix: update data-component attribute for GroupHeading to GroupHeading…
francinelucca 8c38035
fix comment
francinelucca 8c3d244
Merge branch 'main' into chore/implement-adr-023
francinelucca 8ca6eac
add data-component attribute to Pagination
francinelucca ddca738
Merge branch 'chore/implement-adr-023' of github.com:primer/react int…
francinelucca 6f96ebd
Add data-component attributes to TextInput components for improved ac…
francinelucca 17f2bf0
test: add nested ActionList data-component attribute tests for Filter…
francinelucca ff94d66
Merge branch 'main' into chore/implement-adr-023
francinelucca 79e42d4
Merge branch 'chore/implement-adr-023' of github.com:primer/react int…
francinelucca b05df83
test: enhance data-component attribute tests for FilteredActionList a…
francinelucca db67cc2
test: add data-component attribute tests for Table and Pagination com…
francinelucca e71ce27
test: add data-component attribute tests for Table.Header and Table.S…
francinelucca f2b0a1f
test: add data-component attribute to Button and ButtonReset components
francinelucca e94fe52
test: add data-component attribute for LinkButton and its tests
francinelucca 8c886da
test: add data-component attribute to Link component and its tests
francinelucca 76bb50d
test: add data-component attributes for SelectPanel.CloseButton and S…
francinelucca bba65c1
test: add stable data-component selectors to DataTable, Button, Link,…
francinelucca 9aaead8
rearrange stuff
francinelucca 8429e82
chore: auto-fix lint and formatting issues
francinelucca a874ad0
Merge branch 'main' of github.com:primer/react into chore/implement-a…
francinelucca 34ac550
chore: update octicon
francinelucca 6e784d9
Merge branch 'chore/implement-adr-023' of github.com:primer/react int…
francinelucca 8e7bf4c
Merge branch 'main' into chore/implement-adr-023
francinelucca e20e7a9
test(vrt): update snapshots
francinelucca 5f52ac4
Merge branch 'main' into chore/implement-adr-023
francinelucca b6f32bf
test: add implementsClassName for FilteredActionList component
francinelucca 21cbd6d
test(vrt): update snapshots
francinelucca 1e18968
Revert "test(vrt): update snapshots"
francinelucca 1cbc315
Revert "test(vrt): update snapshots"
francinelucca 2d13445
Merge branch 'main' into chore/implement-adr-023
francinelucca 2eb3867
remove unnecessary ActionList.Item.Wrapper
francinelucca b4a9532
Merge branch 'chore/implement-adr-023' of github.com:primer/react int…
francinelucca 5a607d3
data-component fix for ButtonReset
francinelucca 7d57382
Update packages/react/src/ActionBar/ActionBar.tsx
francinelucca f7829b8
Update .changeset/datatable-stable-selectors.md
francinelucca f44ccfb
Merge branch 'main' into chore/implement-adr-023
francinelucca a3e4ba9
Merge branch 'main' into chore/implement-adr-023
francinelucca 60aa35f
Merge branch 'main' into chore/implement-adr-023
francinelucca a0b9c60
Merge branch 'main' into chore/implement-adr-023
francinelucca b8dc78b
test(vrt): update snapshots
francinelucca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.