JPA Extensions concerning the search index (https://jira.pvtool.org/b…#3
Open
moritz-bayer wants to merge 4 commits into
Open
JPA Extensions concerning the search index (https://jira.pvtool.org/b…#3moritz-bayer wants to merge 4 commits into
moritz-bayer wants to merge 4 commits into
Conversation
stefanseifert
requested changes
Apr 28, 2020
Member
stefanseifert
left a comment
stefanseifert
left a comment
There was a problem hiding this comment.
thanks for the PR, lgtm in general.
i've noticed that you've used tabs instead of spaces in all changes to the XML/XSL/XSD files. please convert those two spaces to be in line with the existing code.
fixed code formatting issues found in code review search-index was written twice/entity due to a double entry in platform.xml. Also fixed.
regenerate schema code with latest SDK xsd.exe prepare documentation of new fields
Member
|
not all new fields were added to the XSD - i've added them and regenerated the schema code with a current version of xsd.exe. please update the README file as well - i've already added lines for the new fields, please enter a documentation instead of the "???" |
stefanseifert
force-pushed
the
master
branch
2 times, most recently
from
2fd0716 to
6cd8c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rowse/VKO-3070)
Nach besten Wissen und Gewissen in dem Projekt umgesetzt.