Skip to content

A flurry of adjustments and some additional content#252

Open
fsoubelet wants to merge 112 commits into
masterfrom
corrections
Open

A flurry of adjustments and some additional content#252
fsoubelet wants to merge 112 commits into
masterfrom
corrections

Conversation

@fsoubelet
Copy link
Copy Markdown
Member

@fsoubelet fsoubelet commented May 12, 2026

This PR is an implementation of a long list of "fixes" for things I noticed while I was looking through every page to check the zensical builds from #237.

It is difficult to make a summary since most changes range from "typo" to "update something outdated" to "clarify that" etc. For now, I have left the Changes.md file that lists some of those, as an indication for the reviewer, if it helps. It will be removed before merging.

There are a few more substantial changes, namely removing (commenting out from the nav) some pages in the Physics section, and writing a little something in some others that were empty (harpy, optics, etc). They should jump out to the eye in the diffs since it's a full blown page.

I recommend having a look at the build from time to time for a better idea of what these changes result into :)

For me to remember:

  • Remove Changes.md file

@fsoubelet fsoubelet requested a review from jgray-19 May 12, 2026 06:35
@fsoubelet fsoubelet self-assigned this May 12, 2026
@fsoubelet fsoubelet added Type: Documentation Improvements, updates and fixes to the documentation. Priority: Medium Work on this. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality. Status: Review Needed Work currently stopped, untils someone else reviews it. labels May 12, 2026
Copy link
Copy Markdown
Member Author

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to help guide during your review. Thank so much zensical for warning about invalid refs etc at build time now :)

Comment thread docs/guis/about.md

The GUIs can be started from your development environment or via deployed `.jnlp` from the archives:
<!-- TODO: Add SbS and RDT Feeddown GUIs here when pages are ready. -->
<!-- TODO: Add RDT Feeddown GUI here when pages are ready. -->
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because SbS is not a full GUI to start in and of itself, it comes from the BetaBeat GUI now.

/afs/cern.ch/eng/sl/lintrack/LHC_commissioning2022/
```

<!-- TODO: also one entry for IR5 RWS measurements -->
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was already here

Comment on lines -9 to -16
??? tip "Results Visualization"

Various results graphs and the scripts to make them are available in `lintrack`:

```
/afs/cern.ch/eng/sl/lintrack/LHC_commissioning2025/
```

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folder does not exist. I guess if I don't make them... 🤷‍♂️

Comment on lines +3 to +4
This section documents the physics and methods that underpin the OMC team's optics measurement activities.
The connecting thread across all methods is the extraction of optics quantities (optics functions, dispersion, coupling, resonance driving terms etc) from turn-by-turn BPM data, and their comparison to a reference model to identify and correct lattice imperfections.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole page was depressingly empty, so I wrote a few very quick word to introduce different sections. Eager for feedback on these pages the most.

Comment on lines +7 to +8
!!! tip "Primary Reference"
The algorithm and its derivations are described in [Malina et al., IPAC2022][malina_harpy]{target=_blank}: *Harpy: A Fast, Simple and Accurate Harmonic Analysis with Error Propagation*.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a quick overview of the main points behind harpy's workflow in this page, based on both the referenced IPAC paper and the code itself. Very open to feedback on this page.

Comment thread mkdocs.yml
Comment on lines -152 to -157
- IRNL Corrections:
- About: packages/irnl/about.md
- ↪ On Github: https://github.com/pylhc/irnl_rdt_correction
- MESS:
- About: packages/mess/about.md
- ↪ On Github: https://github.com/pylhc/MESS
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were just duplicates of their GitHub readmes.

Comment thread mkdocs.yml
Comment on lines +159 to +160
- ↪ irnl-corrections: https://github.com/pylhc/irnl_rdt_correction
- ↪ madx-scripts: https://github.com/pylhc/MESS
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added here as links.

Comment thread mkdocs.yml
Comment on lines +213 to +215
# - Linear IR Optics: measurements/physics/ir_linear_optics.md
# - Nonlinear IR Optics: measurements/physics/ir_nonlinear_optics.md
# - 3D-Kicks: measurements/physics/threedkicks.md
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not leave completely empty pages...
If someone feels like writing them ;)

Comment thread docs/packages/about.md
@@ -1,30 +1,33 @@
# The OMC Python Packages

| Package | Description | Version | Documentation | Wiki |
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page is an ugly diff!

Basically, I split the table into two: a first one with our workhorse packages and a second one with adjacent stuff.

See the CI build to view the new page, it's much easier.

Changes from the nominal scenario in your simulation could be including errors tables, orbit bumps, speculative magnet errors, additional elements etc.
It is also easy for the reader to follow along if starting from measurements files.

??? example "Generating the Example Data"
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This big negative diff is thanks to pylhc/MESS#21

Now the admonition points to the files there, which is cleaner and also allows accessing them without AFS access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Priority: Medium Work on this. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Documentation Improvements, updates and fixes to the documentation. Type: Maintenance Improvements in the code, that are not necessarily visible in functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant