Skip to content

gh-138729: Cover inspect.formatannotationrelativeto with tests#138730

Merged
sobolevn merged 3 commits intopython:mainfrom
sobolevn:issue-138729
Sep 10, 2025
Merged

gh-138729: Cover inspect.formatannotationrelativeto with tests#138730
sobolevn merged 3 commits intopython:mainfrom
sobolevn:issue-138729

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Sep 10, 2025

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 10, 2025
@bedevere-app bedevere-app Bot added awaiting core review tests Tests in the Lib/test dir labels Sep 10, 2025
@sobolevn sobolevn changed the title gh-1387729: Cover inspect.formatannotationrelativeto with tests gh-138729: Cover inspect.formatannotationrelativeto with tests Sep 10, 2025
Comment thread Lib/test/test_inspect/test_inspect.py
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Comment thread Lib/test/test_inspect/test_inspect.py Outdated
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sobolevn
Copy link
Copy Markdown
Member Author

@serhiy-storchaka thank you for your guidance, great review as always!

@sobolevn sobolevn merged commit f5fa336 into python:main Sep 10, 2025
47 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2025
pythonGH-138730)

(cherry picked from commit f5fa336)

Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f5fa336579d124e389b1c36a5431e7908aaf5e53 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 10, 2025

GH-138747 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 10, 2025
sobolevn added a commit to sobolevn/cpython that referenced this pull request Sep 10, 2025
…th tests (pythonGH-138730)

(cherry picked from commit f5fa336)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Sep 10, 2025

GH-138748 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 10, 2025
sobolevn added a commit that referenced this pull request Sep 10, 2025
encukou pushed a commit that referenced this pull request Oct 7, 2025
…ts (GH-138730) (GH-138747)

(cherry picked from commit f5fa336)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants