gh-139349: fix init dataclass Console init with value ignore repr error#139351
gh-139349: fix init dataclass Console init with value ignore repr error#139351yihong0618 wants to merge 3 commits intopython:mainfrom yihong0618:hy/close_issue_139349
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
left a comment
There was a problem hiding this comment.
I don't think we should use Console before prepare() has been called. Thus, this should likely not be fixed like that.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
There was a problem hiding this comment.
All the console interface is a private implementation detail (_pyrepl is private and _pyrepl.readline._wrapper.reader is even more private, so no one should directly access it; if one incorrectly uses UnixConsole(), then something wrong may happen). I am still unconvinced that we should do anything here. I'll let @pablogsal or @ambv decide on the course of action here (though just removing console from the repr might be fine; however no NEWS should be added IMO).
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
init it with default value to avoid repr error