gh-141431: Preserve UTC semantics for ZIP timestamps#143868
Closed
priyanshu2282-cyber wants to merge 3 commits intopython:mainfrom
Closed
gh-141431: Preserve UTC semantics for ZIP timestamps#143868priyanshu2282-cyber wants to merge 3 commits intopython:mainfrom
priyanshu2282-cyber wants to merge 3 commits intopython:mainfrom
Conversation
priyanshu2282-cyber
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
Contributor
Author
|
After further investigation, this change alters zipimport timestamp semantics and affects multiple existing tests that rely on current local-time behavior. Fixing this properly would require a broader discussion and coordinated test updates, so I’m closing this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zip file timestamps don’t store timezone information. Using local time can make files inside zipapps look stale when moved between timezones. This change treats DOS timestamps as UTC while keeping zipimport safe during startup.
.pycfile in zipapp can be marked as stale if opened in a different timezone than the one it was created in #141431