gh-143986: Modernize Lib/uuid.py: use f-strings#143985
Closed
tonghuaroot wants to merge 2 commits intopython:mainfrom
Closed
gh-143986: Modernize Lib/uuid.py: use f-strings#143985tonghuaroot wants to merge 2 commits intopython:mainfrom
tonghuaroot wants to merge 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
1056131 to
9cf34f4
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
eb8b475 to
efc8007
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lib/uuid.pycurrently uses older string formatting methods (%operator and.format()) in a few places. This task resolves to modernizing these to use f-strings (PEP 498) for improved readability and consistency with modern Python codebases.Proposed Changes
'%s(%r)' % (self.__class__.__name__, str(self))withf'{self.__class__.__name__}({str(self)!r})'inUUID.__repr__.os.fsencode('(%s)' % ip_addr)withos.fsencode(f'({ip_addr})')in_arp_getnode.assert False, '_random_getnode() returned invalid value: {}'.format(_node)withf-stringversion ingetnode.Verification
python Lib/test/test_uuid.pyto ensure all tests pass.