Added ice phandle to UFS node#1056
Open
kkartik-qcom wants to merge 1 commit intoqualcomm-linux:tech/all/dt/pakalafrom
Open
Added ice phandle to UFS node#1056kkartik-qcom wants to merge 1 commit intoqualcomm-linux:tech/all/dt/pakalafrom
kkartik-qcom wants to merge 1 commit intoqualcomm-linux:tech/all/dt/pakalafrom
Conversation
qcomlnxci
requested review from
a team,
aiquny,
mukeshojha-linux and
ndechesne
and removed request for
a team
kkartik-qcom
force-pushed
the
ice_config_kartik
branch
2 times, most recently
from
17bad9c to
3d38ecc
Compare
kkartik-qcom
force-pushed
the
ice_config_kartik
branch
from
3d38ecc to
4440dcb
Compare
kkartik-qcom
changed the title
kkartik-qcom
force-pushed
the
ice_config_kartik
branch
from
4440dcb to
3c21d11
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kuld-sing
requested changes
May 5, 2026
kuld-sing
left a comment
kuld-sing
left a comment
There was a problem hiding this comment.
Pls add konrad's tag in commit message.
Reviewed-by: Konrad Dybcio konrad.dybcio@oss.qualcomm.com
kkartik-qcom
force-pushed
the
ice_config_kartik
branch
from
3c21d11 to
177a068
Compare
The Inline Crypto Engine (ICE) exists as a standalone DT node, but the UFS node lacks the required qcom,ice phandle reference. Add the qcom,ice property to explicitly associate the UFS controller with its ICE instance. Fixes: d288abc ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC") Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://lore.kernel.org/lkml/20260429-sm8750_ice_dt_fix-v1-1-2540dc337082@oss.qualcomm.com/ Signed-off-by: Kumar Kartik <kkartik@qti.qualcomm.com>
kkartik-qcom
force-pushed
the
ice_config_kartik
branch
from
177a068 to
7ead5f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
UFS node lacks the required qcom,ice phandle reference.
Add the qcom,ice property to explicitly associate the UFS controller
with its ICE instance.
CRs-Fixed: 4520138