Spawn merge pipeline from new compactor#6284
Merged
nadav-govari merged 3 commits intonadav/feature-split-mergesfrom Apr 13, 2026
Merged
Spawn merge pipeline from new compactor#6284nadav-govari merged 3 commits intonadav/feature-split-mergesfrom
nadav-govari merged 3 commits intonadav/feature-split-mergesfrom
Conversation
nadav-govari
commented
Apr 9, 2026
| .set_throughput_limiter_opt(self.io_throughput_limiter.clone()) | ||
| .set_component("split_downloader_merge"); | ||
| let merge_executor_io_controls = | ||
| split_downloader_io_controls.clone().set_component("merger"); |
Collaborator
Author
There was a problem hiding this comment.
TODO: throughput throttling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the MergeScratch to not use the tracking objects that the MergePlanner used to keep track of ongoing merges, since merges are now one shots and are tracked in short-lived objects directly.
I'm trying to keep the existing stuff from breaking so that we can still run CI on these PRs. As a result there will be a decent amount of dead code that I'll need to go back and change.
How was this PR tested?
Unit tests. Nothing to really test significantly yet.