Use unchecked constructor for SCG.List<T> to bypass redundant bounds checks

Author: rameel

Ramstack.Structures/Collections/ArrayViewExtensions.cs

@@ -149,9 +149,13 @@ public static ArrayView<T> AsView<T>(this List<T>? list)
         if (list is not null)
         {
             var array = ListAccessor<T>.GetArray(list);
-            var count = Math.Min(list.Count, array.Length);
+            _ = array.Length;
 
-            return new ArrayView<T>(array, 0, count);
+            //
+            // SCG.List<T> maintains internal invariants, so we can safely use the unchecked constructor
+            // to bypass redundant bounds checks for better performance.
+            //
+            return new ArrayView<T>(array, 0, list.Count, unused: 0);
         }
 
         return ArrayView<T>.Empty;

Ramstack.Structures/Collections/ArrayView`1.cs

@@ -112,7 +112,7 @@ public ArrayView(T[] array, int index, int length)
     /// <param name="length">The number of elements in the range.</param>
     /// <param name="unused">Unused parameter, exists solely to disambiguate overloads.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    private ArrayView(T[] array, int index, int length, int unused)
+    internal ArrayView(T[] array, int index, int length, int unused)
     {
         _index = index;
         _count = length;