Topic/rdkemw 16330 1 by jthomp007c · Pull Request #194 · rdkcentral/control

jthomp007c · 2026-04-06T13:21:07Z

No description provided.

Reason for Chanage: RDK-E uses a boolean to report whether Networked Standby Mode is enabled, rather than a JsonObject Test Procedure: Confirm that Control Manager enters NSM when it should Priority: P0 Signed-off-by: Jason Thomson <jason_thomson@comcast.com>

Copilot

Pull request overview

Updates the Thunder PowerManager integration to consume typed JSON-RPC results (bool/string) for specific calls, aligning Control Manager behavior with NSM (network standby mode) being a boolean.

Changes:

Add typed helper APIs to ctrlm_thunder_plugin_t for invoking Thunder methods that return bool or string.
Update PowerManager Thunder plugin calls to use the new typed helpers for getNetworkStandbyMode and getLastWakeupReason.
Update changelog and fix minor comment grammar.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`src/thunder/ctrlm_thunder_plugin.h`	Adds new typed invoke helpers and adjusts related API comments.
`src/thunder/ctrlm_thunder_plugin.cpp`	Implements `call_plugin_boolean` and `call_plugin_string` Thunder invoke wrappers.
`src/thunder/ctrlm_thunder_plugin_powermanager.cpp`	Switches NSM and wakeup-reason retrieval to the typed helpers.
`CHANGELOG.md`	Adds release entry for `1.1.11p1` referencing the NSM bool update.

Comments suppressed due to low confidence (1)

src/thunder/ctrlm_thunder_plugin.h:153

The call_controller() Doxygen has two @param entries named "params"; the second one appears to describe the response object. This should be @param response (and keep "params" for the request parameters) to prevent incorrect generated docs.

    /**
     * This function is used to call a Thunder Controller method.
     * @param method The method in which the user wants to call.
     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
     * @param params The WPEFramework JsonObject containing the response from the call.  (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
     * @return True if the call succeeded, otherwise False.
     */
    bool call_controller(std::string method, void *params, void *response);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T13:24:32Z

@@ -115,7 +115,7 @@ class ctrlm_thunder_plugin_t {
    bool property_get(std::string property, void *response, unsigned int retries = 0);


The Doxygen for property_get() is describing a "method" parameter, but the function signature takes a "property" string. This makes the API docs misleading; update the @param name/description to match the actual "property" argument (and what it represents).

Copilot · 2026-04-06T13:24:33Z

+    /**
+     * This function is used to call a Thunder Plugin method.
+     * @param method The method in which the user wants to call.
+     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
+     * @param response The WPEFramework JsonObject containing the response from the call.  (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
+     * @return True if the call succeeded, otherwise False.
+     */
+    bool call_plugin_string(std::string method, void *params, std::string *response);
+


The documentation for call_plugin_string() says the response is a WPEFramework JsonObject, but the function actually returns a std::string via the response pointer. Update the @param response description to avoid confusing callers.

Address copilot comments

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T18:02:43Z

-     * @param method The method in which the user wants to call.
+     * This function is used to get a Thunder Plugin property.
+     * @param property The property the user wants to get
     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)


The documentation for property_get() lists an @param "params", but the function signature only takes (property, response, retries). Update the comment to remove/rename that parameter so the header docs match the API.

Suggested change

* @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)

Copilot · 2026-04-08T18:02:43Z

+     * This function is used to call a Thunder Plugin method.
+     * @param method The method in which the user wants to call.
+     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
+     * @param response A pointer a string which will be assigned


call_plugin_string() Doxygen comment is incomplete/grammatically incorrect ("A pointer a string which will be assigned"). Please clarify what the string represents (e.g., method result) and fix the wording so the API contract is unambiguous.

Suggested change

* @param response A pointer a string which will be assigned

* @param response A pointer to a string that will be assigned the method response.

Fix error log

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/thunder/ctrlm_thunder_plugin.h:149

The call_controller() docblock lists "@param params" twice (the second one is describing the response). This makes the generated documentation misleading. Rename the second tag to "@param response" (or equivalent) to match the function signature.

    /**
     * This function is used to call a Thunder Controller method.
     * @param method The method in which the user wants to call.
     * @param params The WPEFramework JsonObject containing the parameters for the call. (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
     * @param params The WPEFramework JsonObject containing the response from the call.  (We can't include WPEFramework headers in controlMgr .h files as their logging macros clash)
     * @return True if the call succeeded, otherwise False.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

egalla204 and others added 7 commits March 6, 2026 10:25

Merge branch 'release/1.1.11'

a84164f

RDKEMW-16330: update CHANGELOG for release 1.1.11p1

98ea5f5

Update ctrlm_thunder_plugin_powermanager.cpp

d98d86e

Update ctrlm_thunder_plugin_powermanager.cpp

d2329ca

Update ctrlm_thunder_plugin_powermanager.cpp

4176268

Adding JSON string method to plugin

11ea30b

jthomp007c requested a review from a team as a code owner April 6, 2026 13:21

Copilot AI review requested due to automatic review settings April 6, 2026 13:21

Copilot started reviewing on behalf of jthomp007c April 6, 2026 13:21 View session

Copilot AI reviewed Apr 6, 2026

View reviewed changes

Update ctrlm_thunder_plugin.h

d35e7da

Address copilot comments

Copilot AI review requested due to automatic review settings April 8, 2026 17:57

Copilot started reviewing on behalf of jthomp007c April 8, 2026 17:59 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Update ctrlm_thunder_plugin.cpp

2a3bc2a

Fix error log

Copilot AI review requested due to automatic review settings April 8, 2026 18:15

Copilot started reviewing on behalf of jthomp007c April 8, 2026 18:16 View session

Update ctrlm_thunder_plugin.h

3fd1df7

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread src/thunder/ctrlm_thunder_plugin.h

Update ctrlm_thunder_plugin.h

ef652ff

Copilot AI review requested due to automatic review settings April 8, 2026 18:50

Copilot started reviewing on behalf of jthomp007c April 8, 2026 18:51 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topic/rdkemw 16330 1#194

Topic/rdkemw 16330 1#194
jthomp007c wants to merge 11 commits into
developfrom
topic/RDKEMW-16330-1

jthomp007c commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -115,7 +115,7 @@ class ctrlm_thunder_plugin_t {
		bool property_get(std::string property, void *response, unsigned int retries = 0);

	* @param response A pointer a string which will be assigned
	* @param response A pointer to a string that will be assigned the method response.

Conversation

jthomp007c commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants