RDKEMW-16814: reduce ble status prints and events by egalla204 · Pull Request #235 · rdkcentral/control

egalla204 · 2026-05-14T23:24:07Z

No description provided.

https://ccp.sys.comcast.net/browse/RDKEMW-16915

rdkcmf-jenkins · 2026-05-14T23:26:36Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/control/235/rdk/components/generic/control
Commit: 6a7f4c3

Report detail: gist'

Copilot

Pull request overview

This PR reduces log/event noise across the Control Manager (ctrlm-main) codebase, with the main functional change being throttling/coalescing of BLE “status print” output and BLE “status event” emissions.

Changes:

Downgrade many high-frequency logs from XLOGD_INFO to XLOGD_DEBUG (DB access, controller lifecycle, BLE GATT services, etc.).
Add BLE-network scheduling to defer/coalesce pairing-table printing (printStatus()) and IARM status events (iarm_event_rcu_status()), instead of printing/emitting on every status update.
Minor adjustments to BLE startup/status output and IR RF database printing verbosity.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/database/ctrlm_db_types.cpp	Reduce DB blob read/write log verbosity (INFO → DEBUG).
src/database/ctrlm_database.cpp	Reduce controller-create log verbosity (INFO → DEBUG).
src/ctrlm_network.h	Add new virtual request handlers for status print/event.
src/ctrlm_network.cpp	Provide base “not implemented” handlers for new status print/event requests.
src/ctrlm_ir_controller.cpp	Reduce IR input device name logging verbosity.
src/ctrlm_controller.cpp	Reduce controller ctor/dtor logging verbosity.
src/ble/hal/blercu/bluez/blegattnotifypipe.cpp	Reduce notify-thread launch logging verbosity.
src/ble/hal/blercu/bleservices/gatt/gatt_remotecontrolservice.cpp	Reduce several “request succeeded / initial value” logs to DEBUG.
src/ble/hal/blercu/bleservices/gatt/gatt_infraredsignal.cpp	Reduce IR characteristic discovery logs to DEBUG.
src/ble/hal/blercu/bleservices/gatt/gatt_infraredservice.cpp	Reduce IR support/code-id logs to DEBUG.
src/ble/hal/blercu/bleservices/gatt/gatt_deviceinfoservice.cpp	Reduce device-info milestone logs to DEBUG and shorten comment.
src/ble/hal/blercu/bleservices/gatt/gatt_batteryservice.cpp	Reduce battery change log to DEBUG.
src/ble/hal/blercu/bleservices/gatt/gatt_audioservice_rdk.cpp	Reduce audio property read logs to DEBUG.
src/ble/ctrlm_ble_rcu_interface.cpp	Reduce managed device listing log; enrich “input dev node found” log.
src/ble/ctrlm_ble_network.h	Add scheduling APIs + defer counters for BLE status print/event throttling.
src/ble/ctrlm_ble_network.cpp	Implement timers + deferred status print/event emission; adjust BLE startup/status logging.
src/ble/ctrlm_ble_controller.cpp	Reduce BLE controller ctor logging verbosity.
src/ble/ctrlm_ble_controller_attr_version.cpp	Reduce BLE version DB read/write logs to DEBUG.
src/attributes/ctrlm_attr_voice.cpp	Reduce voice metrics DB read/write logs to DEBUG.
src/attributes/ctrlm_attr_general.cpp	Reduce general attribute DB read/write logs to DEBUG.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/ble/ctrlm_ble_network.cpp:2018

Same off-by-one issue as schedule_status_print(): event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX is evaluated before incrementing, which permits one extra deferral beyond the configured MAX before forcing an immediate event push. Consider changing the comparison (or the increment/check order) so the configured MAX is enforced as intended.

   THREAD_ID_VALIDATE();
   ctrlm_timeout_destroy(&g_ctrlm_ble_network.event_status_timer_tag);
   if (immediately || event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX) {
      event_status_defer_count_ = 0;
      ctrlm_main_queue_msg_header_t msg;
      errno_t safec_rc = memset_s(&msg, sizeof(msg), 0, sizeof(msg));
      ERR_CHK(safec_rc);
      ctrlm_main_queue_handler_push(CTRLM_HANDLER_NETWORK, (ctrlm_msg_handler_network_t)&ctrlm_obj_network_t::req_process_event_status, &msg, sizeof(msg), NULL, id_);
   } else {
      event_status_defer_count_++;
      g_ctrlm_ble_network.event_status_timer_tag = ctrlm_timeout_create(CTRLM_BLE_EVENT_STATUS_TIMEOUT, ctrlm_ble_event_status_timer_cb, &id_);
   }

rdkcmf-jenkins · 2026-05-15T00:10:53Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/control/235/rdk/components/generic/control
Commit: 57a79f5

Report detail: gist'

rdkcmf-jenkins · 2026-05-15T00:54:14Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 3 files pending identification.

Protex Server Path: /home/blackduck/github/control/235/rdk/components/generic/control
Commit: 231d418

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/ble/ctrlm_ble_network.cpp:2011

In schedule_status_event(), the defer-limit check uses event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX, which effectively permits DEFER_MAX+1 deferrals before forcing an event. If the desired behavior is “trigger once the max is reached”, use >= here as well.

void ctrlm_obj_network_ble_t::schedule_status_event(bool immediately) {
   XLOGD_DEBUG("immediately = <%s>, event_status_defer_count_ = <%d>", immediately ? "TRUE" : "FALSE", event_status_defer_count_);
   THREAD_ID_VALIDATE();
   ctrlm_timeout_destroy(&g_ctrlm_ble_network.event_status_timer_tag);
   if (immediately || event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX) {
      event_status_defer_count_ = 0;
      ctrlm_main_queue_msg_header_t msg;

         XLOGD_TELEMETRY("BLE remote RF pairing state changed to <%s>", ctrlm_rf_pair_state_str(dqm->state));
         state_ = dqm->state;
+         if (state_ == CTRLM_RF_PAIR_STATE_COMPLETE || state_ == CTRLM_RF_PAIR_STATE_IDLE) {
+            // report status in a couple seconds to allow remote data to be received from bluez


rdkcmf-jenkins · 2026-05-15T10:14:12Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: ok
Commit: 231d418
'

dwolaver

Looks solid to me. Ready for QA test

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

src/ble/ctrlm_ble_network.cpp:2002

schedule_status_event() has the same off-by-one behavior as schedule_status_print(): the condition uses event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX while the counter is incremented in the else branch, so you can defer DEFER_MAX + 1 times before forcing an immediate event. Use >= (or increment before checking) if DEFER_MAX is meant to be a strict cap.

   THREAD_ID_VALIDATE();
   ctrlm_timeout_destroy(&g_ctrlm_ble_network.event_status_timer_tag);
   if (immediately || event_status_defer_count_ > CTRLM_BLE_EVENT_STATUS_DEFER_MAX) {
      event_status_defer_count_ = 0;
      ctrlm_main_queue_msg_header_t msg;
      errno_t safec_rc = memset_s(&msg, sizeof(msg), 0, sizeof(msg));
      ERR_CHK(safec_rc);
      ctrlm_main_queue_handler_push(CTRLM_HANDLER_NETWORK, (ctrlm_msg_handler_network_t)&ctrlm_obj_network_t::req_process_event_status, &msg, sizeof(msg), NULL, id_);
   } else {
      event_status_defer_count_++;
      g_ctrlm_ble_network.event_status_timer_tag = ctrlm_timeout_create(CTRLM_BLE_EVENT_STATUS_TIMEOUT, ctrlm_ble_event_status_timer_cb, &id_);
   }

src/ble/ctrlm_ble_network.cpp:306

The constructor explicitly resets the upgrade timer tags to 0, but the newly added print_status_timer_tag / event_status_timer_tag fields in g_ctrlm_ble_network are not similarly initialized here. Initializing them to 0 alongside the existing timers would be more robust/consistent, especially if the BLE network object is ever reconstructed in-process.

   g_ctrlm_ble_network.upgrade_controllers_timer_tag = 0;
   g_ctrlm_ble_network.upgrade_pause_timer_tag = 0;

+   ctrlm_timeout_destroy(&g_ctrlm_ble_network.print_status_timer_tag);
+   if (immediately || print_status_defer_count_ > CTRLM_BLE_PRINT_STATUS_DEFER_MAX) {
+      print_status_defer_count_ = 0;
+      ctrlm_main_queue_msg_header_t msg;
+      errno_t safec_rc = memset_s(&msg, sizeof(msg), 0, sizeof(msg));
+      ERR_CHK(safec_rc);
+      ctrlm_main_queue_handler_push(CTRLM_HANDLER_NETWORK, (ctrlm_msg_handler_network_t)&ctrlm_obj_network_t::req_process_print_status, &msg, sizeof(msg), NULL, id_);
+   } else {
+      print_status_defer_count_++;
+      g_ctrlm_ble_network.print_status_timer_tag = ctrlm_timeout_create(CTRLM_BLE_PRINT_STATUS_TIMEOUT, ctrlm_ble_print_status_timer_cb, &id_);
+   }


               case CTRLM_HAL_BLE_PROPERTY_BATTERY_LEVEL:
                  controller->setBatteryPercent(dqm->rcu_data.battery_level, true);
-                  print_status = false;
+                  XLOGD_INFO("Controller <%s> battery level changed to <%u%%>", controller->ieee_address_get().to_string().c_str(), dqm->rcu_data.battery_level);


egalla204 and others added 3 commits April 9, 2026 15:07

Release/1.1.12 (#200)

414b130

https://ccp.sys.comcast.net/browse/RDKEMW-16915

Merge branch 'release/1.1.12'

02e0576

RDKEMW-16814: reduce ble status prints and events

6a7f4c3

Copilot AI review requested due to automatic review settings May 14, 2026 23:24

egalla204 requested a review from a team as a code owner May 14, 2026 23:24

Copilot started reviewing on behalf of egalla204 May 14, 2026 23:24 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread src/ble/ctrlm_ble_network.cpp

Comment thread src/ble/ctrlm_ble_network.cpp Outdated

Comment thread src/ble/ctrlm_ble_network.cpp Outdated

apply some copilot review suggestions

57a79f5

egalla204 requested a review from Copilot May 14, 2026 23:49

Copilot started reviewing on behalf of egalla204 May 14, 2026 23:49 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread src/ble/ctrlm_ble_network.cpp

Comment thread src/ble/ctrlm_ble_network.cpp Outdated

Comment thread src/ctrlm_controller.cpp Outdated

some more copilot comments

231d418

egalla204 requested a review from Copilot May 15, 2026 00:51

Copilot started reviewing on behalf of egalla204 May 15, 2026 00:52 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

fix a comment

22616f6

dwolaver reviewed May 18, 2026

View reviewed changes

Merge branch 'develop' into RDKEMW-16814_reduce_ble_logging

05fb3fe

Copilot AI review requested due to automatic review settings May 18, 2026 23:29

Copilot started reviewing on behalf of egalla204 May 18, 2026 23:30 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-16814: reduce ble status prints and events#235

RDKEMW-16814: reduce ble status prints and events#235
egalla204 wants to merge 7 commits into
developfrom
RDKEMW-16814_reduce_ble_logging

egalla204 commented May 14, 2026

Uh oh!

rdkcmf-jenkins commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

dwolaver left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

egalla204 commented May 14, 2026

Uh oh!

rdkcmf-jenkins commented May 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

dwolaver left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants