Skip to content

RDKB-63899 : Zebra restart marker observed in selfheal#296

Open
aj970-crypto wants to merge 4 commits into
developfrom
feature/RDKB-63899
Open

RDKB-63899 : Zebra restart marker observed in selfheal#296
aj970-crypto wants to merge 4 commits into
developfrom
feature/RDKB-63899

Conversation

@aj970-crypto
Copy link
Copy Markdown
Contributor

RDKB-63899 : Zebra restart marker observed in selfheal

Reason for change: Adding logs for tracking the issue in future if reproduced
Test Procedure: None
Risks: Low
Priority: P1

Copilot AI review requested due to automatic review settings April 29, 2026 12:06
@aj970-crypto aj970-crypto requested review from a team as code owners April 29, 2026 12:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional logging around routed/zebra startup and LAN/WAN event handling to help diagnose “zebra restart marker observed in selfheal” scenarios (RDKB-63899).

Changes:

  • Add debug logs in service_routed (C) for function entry, bridge mode, zebra start attempt, and LAN/WAN readiness.
  • Add event-trigger logs in init scripts for wan-status / lan-status routed triggers.
  • Add additional LAN handler logs around ipv4 status handling, lan-status updates, and uptime markers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
source/service_routed/service_routed.c Adds log statements around routed init and zebra start/verification flow.
source/scripts/init/service.d/service_routed.sh Logs when WAN/LAN “started” triggers routed start.
source/scripts/init/service.d/lan_handler.sh Adds more detailed LAN up / lan-status / uptime logging for troubleshooting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread source/scripts/init/service.d/service_routed.sh
Comment thread source/service_routed/service_routed.c
Comment thread source/service_routed/service_routed.c Outdated
Comment thread source/scripts/init/service.d/service_routed.sh
Signed-off-by: aj970 <akshaya_j@comcast.com>
Copilot AI review requested due to automatic review settings May 8, 2026 06:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread source/service_routed/service_routed.c
rajkamal-cv
rajkamal-cv previously approved these changes May 8, 2026
if [ -e "/usr/bin/print_uptime" ]; then
/usr/bin/print_uptime "Laninit_complete"
echo_t "LAN HANDLER : Laninit_complete uptime: $(cut -d. -f1 /proc/uptime)"
echo_t "LAN HANDLER : Checking lan-status after lan init complete, lan-status = $(sysevent get lan-status)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lan init complete will be after lan-status started , remove extra sysevent get

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this log because I observed two Laninit_complete uptime entries in the logs. In the boottime.log, the first occurrence was considered even though LAN was not started at that point, while only during the second occurrence the LAN actually gets started. This check was added to confirm the lan-status during both instances.

Comment thread source/scripts/init/service.d/lan_handler.sh Outdated
Comment thread source/scripts/init/service.d/lan_handler.sh Outdated
Comment thread source/scripts/init/service.d/lan_handler.sh Outdated
fi

elif [ x"ready" != x`sysevent get start-misc` ] && ( [ "$MANUFACTURE" = "Technicolor" ] || [ "$MANUFACTURE" = "Sercomm" ] ) ; then
echo_t "LAN HANDLER : box is from Technicolor or Sercomm, setting lan-status to started"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this comment to verify whether execution is reaching this point. This helps identify where the flow is breaking in cases where the LAN is not getting started.

Comment thread source/scripts/init/service.d/lan_handler.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants