support symbolication with native frames#181
Merged
Merged
Conversation
hoxyq
reviewed
Jun 24, 2025
hoxyq
left a comment
There was a problem hiding this comment.
Could you please add a corresponding test to ErrorStackParser.test.ts?
28bcecb to
123bb17
Compare
Author
Done |
hoxyq
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make "(native)" RN frames work the same way as "<anonymous>".
React Native uses these when a call is made to a native function.
Up until now, symbolication was failing when these were encountered.
Now, symbolication will leave these lines as they are. These lines will be ignore-listed if the function calling the native function was ignore-listed. (Which is how "<anonymous>" works at the moment)
Test plan
npm run testpasses.Also, for an error stack that includes "(native)":
Before: Symbolication failed
After: Symbolication succeeded as expected:


Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.