Skip to content

chore(config): add lightspeed notebooks configuration schema#4778

Draft
its-mitesh-kumar wants to merge 1 commit intoredhat-developer:mainfrom
its-mitesh-kumar:chore/add-lightspeed-notebooks-config-schema
Draft

chore(config): add lightspeed notebooks configuration schema#4778
its-mitesh-kumar wants to merge 1 commit intoredhat-developer:mainfrom
its-mitesh-kumar:chore/add-lightspeed-notebooks-config-schema

Conversation

@its-mitesh-kumar
Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar commented May 7, 2026

Description

  • Add lightspeed.notebooks configuration schema to packages/app/config.d.ts
  • Also added lightspeed.prompts configuration schema to packages/app/config.d.ts which I found missing. Without the prompts schema, custom user prompts configured in app-config.yaml would not be readable by the frontend

Which issue(s) does this PR fix

Depends

redhat-developer/rhdh-plugins#3062

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@openshift-ci openshift-ci Bot requested review from kadel and schultzp2020 May 7, 2026 23:22
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@its-mitesh-kumar its-mitesh-kumar marked this pull request as draft May 7, 2026 23:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.49%. Comparing base (9cb4dba) to head (c1e3fdf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4778       +/-   ##
===========================================
+ Coverage   40.88%   69.49%   +28.60%     
===========================================
  Files         119      109       -10     
  Lines        2228     4710     +2482     
  Branches      562      537       -25     
===========================================
+ Hits          911     3273     +2362     
- Misses       1311     1437      +126     
+ Partials        6        0        -6     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 38.65% <ø> (-2.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb4dba...c1e3fdf. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Image was built and published successfully. It is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant