Skip to content

updating dockerfile for go 1.26 and ubi 10#128

Merged
acornett21 merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:main
May 6, 2026
Merged

updating dockerfile for go 1.26 and ubi 10#128
acornett21 merged 1 commit intoredhat-openshift-ecosystem:mainfrom
acornett21:main

Conversation

@acornett21
Copy link
Copy Markdown
Contributor

@acornett21 acornett21 commented May 6, 2026

Summary by CodeRabbit

  • Chores
    • Updated Docker base images for the builder and runtime stages to improve compatibility and performance.

Signed-off-by: Adam D. Cornett <adc@redhat.com>
@openshift-ci openshift-ci Bot requested review from bcrochet and komish May 6, 2026 20:50
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

Walkthrough

Dockerfile base images are updated to newer versions: the builder stage now uses golang:1.26 (previously 1.25) and the runtime stage uses ubi10/ubi-micro:latest (previously ubi9/ubi-micro:latest). Build and runtime flow remain functionally unchanged.

Changes

Dockerfile Base Image Updates

Layer / File(s) Summary
Base Image Versions
Dockerfile
Builder stage golang version bumped from 1.25 to 1.26; runtime stage UBI image bumped from ubi9 to ubi10/ubi-micro:latest.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Structure And Quality ⚠️ Warning Test assertions lack meaningful failure messages. All 11 Expect() calls are missing message arguments to help diagnose failures. Add failure message strings to all Expect() calls. Example: Expect(Version.Version).To(Equal(ldflagVersionOverride), "version should match ldflags override")
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically summarizes the main changes in the pull request: updating the Dockerfile to use Go 1.26 and UBI 10 base images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed All Ginkgo test names in version_test.go are stable and deterministic. No dynamic information (pod names, timestamps, UUIDs, node names, namespaces, IP addresses, format strings) found in test names.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

18-18: ⚡ Quick win

Pin the runtime base image to a digest instead of :latest.

The ubi10/ubi-micro:latest tag is mutable and can change between builds, causing non-deterministic rebuilds and unexpected runtime changes. Red Hat's guidance recommends pinning images by immutable digest for production reproducibility. Retrieve the digest using skopeo inspect --format 'Digest: {{.Digest}}' docker://registry.access.redhat.com/ubi10/ubi-micro:latest (or podman equivalent), then pin it in the Dockerfile:

Suggested change
-FROM registry.access.redhat.com/ubi10/ubi-micro:latest
+ARG UBI_MICRO_IMAGE=registry.access.redhat.com/ubi10/ubi-micro@sha256:<retrieved_digest>
+FROM ${UBI_MICRO_IMAGE}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile` at line 18, The Dockerfile currently uses a mutable image tag in
the FROM line ("registry.access.redhat.com/ubi10/ubi-micro:latest"); replace
that tag with the image's immutable digest by running a tooling command such as
"skopeo inspect" or "podman inspect" to obtain the digest (e.g., Digest:
sha256:...) and update the FROM to
"registry.access.redhat.com/ubi10/ubi-micro@sha256:<digest>" so builds are
deterministic and reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Dockerfile`:
- Line 18: The Dockerfile currently uses a mutable image tag in the FROM line
("registry.access.redhat.com/ubi10/ubi-micro:latest"); replace that tag with the
image's immutable digest by running a tooling command such as "skopeo inspect"
or "podman inspect" to obtain the digest (e.g., Digest: sha256:...) and update
the FROM to "registry.access.redhat.com/ubi10/ubi-micro@sha256:<digest>" so
builds are deterministic and reproducible.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cfa5982c-60b4-45bc-b07c-1498e27b38a9

📥 Commits

Reviewing files that changed from the base of the PR and between 5ef790f and 7153941.

📒 Files selected for processing (1)
  • Dockerfile

@acornett21 acornett21 merged commit d9afd24 into redhat-openshift-ecosystem:main May 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant