Skip to content

Potential fix for code scanning alert no. 1: Unsafe shell command constructed from library input #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
n-rodriguez wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 1: Unsafe shell command constructed from library input #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/grack/git.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ def popen_env
end

def config_setting(service_name)
service_name = service_name.gsub('-', '')
service_name = service_name.to_s.gsub('-', '')
unless %w[uploadpack receivepack].include?(service_name)
raise ArgumentError, "Unsupported service name: #{service_name}"
end

setting = config("http.#{service_name}")

if service_name == 'uploadpack'
Expand All @@ -53,6 +57,11 @@ def config_setting(service_name)
end

def config(config_name)
config_name = config_name.to_s
unless /\Ahttp\.(uploadpack|receivepack)\z/.match?(config_name)
raise ArgumentError, "Unsupported config name: #{config_name}"
end

execute(%W(config #{config_name}))
end

Expand Down