Skip to content

nit: add themeing to AI Bar #9210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royendo merged 1 commit into from
Apr 10, 2026
+10 −6
Merged

nit: add themeing to AI Bar #9210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions web-admin/src/routes/-/embed/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import { ResourceKind } from "@rilldata/web-common/features/entity-management/resource-selectors.ts";
import { featureFlags } from "@rilldata/web-common/features/feature-flags";
import DashboardChat from "@rilldata/web-common/features/chat/DashboardChat.svelte";
import ThemeProvider from "@rilldata/web-common/features/dashboards/ThemeProvider.svelte";
import { activeDashboardTheme } from "@rilldata/web-common/features/themes/active-dashboard-theme";
import {
createIframeRPCHandler,
emitNotification,
Expand Down Expand Up @@ -134,12 +136,14 @@
authContext="embed"
>
{#if showTopBar}
<div
class="flex items-center w-full pr-4 py-1 min-h-[2.5rem]"
class:border-b={!onProjectPage}
>
<EmbedHeader {activeResource} {navigationEnabled} />
</div>
<ThemeProvider theme={$activeDashboardTheme} applyLayout={false}>
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when there is no active dashboard?

Copy link
Copy Markdown
Contributor Author

@royendo royendo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever an embed state without an active dashboard?

Copy link
Copy Markdown
Contributor Author

@royendo royendo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, when you embed the home page; its cleared

So it's safe — when there's no active dashboard, the ThemeProvider just passes through with default/unthemed styling. Same behavior as DashboardChat.svelte which uses the same pattern.

<div
class="flex items-center w-full pr-4 py-1 min-h-[2.5rem] bg-surface-subtle"
class:border-b={!onProjectPage}
>
<EmbedHeader {activeResource} {navigationEnabled} />
</div>
</ThemeProvider>
{/if}

<div class="flex h-full overflow-hidden">
Expand Down
Loading