Skip to content

Add missing before/on/after plugin hooks across compiler event lifecycle#1707

Closed
Copilot wants to merge 5 commits into
masterfrom
copilot/ensure-before-action-during-after-events
Closed

Add missing before/on/after plugin hooks across compiler event lifecycle#1707
Copilot wants to merge 5 commits into
masterfrom
copilot/ensure-before-action-during-after-events

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 12, 2026 •
edited
Loading

  • Confirm feedback requires v1-based implementation
  • Fetch and switch to a branch based on origin/v1
  • Audit v1 plugin events for missing before/action/after triads
  • Implement minimal triad additions for missing v1 events
  • Update focused tests for added event emissions
  • Update plugin docs for new v1 event hooks
  • Run lint/build/tests and finalize reply to PR comment

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request
Ensure we have beforeAction/action/AfterAction for every single plugin event #1552
Open
Copilot AI and others added 4 commits May 12, 2026 16:24
@TwitchBronBron
feat: add before/on/after hooks across plugin events
4922011 
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f

Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
@TwitchBronBron
chore: refine lifecycle event typing names
176f617 
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f

Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
@TwitchBronBron
docs: clarify onProgramCreate lifecycle semantics
6a39954 
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f

Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
@TwitchBronBron
test: add brs dispose event coverage
f0274b9 
Agent-Logs-Url: https://github.com/rokucommunity/brighterscript/sessions/a7fc302f-ff61-4651-b61a-5bd4306ce21f

Co-authored-by: TwitchBronBron <2544493+TwitchBronBron@users.noreply.github.com>
Copilot AI changed the title [WIP] Ensure every plugin event has beforeAction, action, and afterAction Add missing before/on/after plugin hooks across compiler event lifecycle May 12, 2026
Copilot AI requested a review from TwitchBronBron May 12, 2026 16:33
@TwitchBronBron
Copy link
Copy Markdown
Member

TwitchBronBron commented May 13, 2026

@copilot no! This isn't right at all. I wanted you to check out the v1 branch, and implement these changes in a branch off of the v1 branch, into the v1 branch.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 13, 2026

@copilot no! This isn't right at all. I wanted you to check out the v1 branch, and implement these changes in a branch off of the v1 branch, into the v1 branch.

I can’t rewrite this existing PR branch to be v1-based from this environment because only non-force pushes are allowed on the current PR branch. If you retarget this PR to v1 (or provide a fresh v1-targeted PR branch), I can apply and validate the changes there immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwitchBronBron TwitchBronBron Awaiting requested review from TwitchBronBron

Assignees

@TwitchBronBron TwitchBronBron

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure we have beforeAction/action/AfterAction for every single plugin event

2 participants

@TwitchBronBron