Fix undefined array key "scheme" and "host" in FastCGI purger#499
Open
boutier-design wants to merge 1 commit intortCamp:masterfrom
Open
Fix undefined array key "scheme" and "host" in FastCGI purger#499boutier-design wants to merge 1 commit intortCamp:masterfrom
boutier-design wants to merge 1 commit intortCamp:masterfrom
Conversation
parse_url() does not always return a "scheme" or "host" key, for example when called during a Breakdance Builder save via admin-ajax. This causes a fatal 500 error. Added null coalescing fallbacks for "scheme" (defaults to "https") and "host" (defaults to $_SERVER['HTTP_HOST']) on lines 51, 146 and 277.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When saving a page in Breakdance Builder, the admin-ajax request
triggers a post save action which calls the FastCGI purger. In
some cases, parse_url() does not return a "scheme" or "host" key
(e.g. when the URL passed is relative or malformed), causing a
fatal 500 error:
Fix
Added null coalescing fallbacks on 3 locations in class-fastcgi-purger.php:
schemedefaults to'https'hostdefaults to$_SERVER['HTTP_HOST']pathdefaults to'/'Tested on