Skip to content

docs: fix stale corepc-node references#574

Merged
tcharding merged 1 commit into
rust-bitcoin:masterfrom
satsfy:fix-bitcoind-related-idioms
May 5, 2026
Merged

docs: fix stale corepc-node references#574
tcharding merged 1 commit into
rust-bitcoin:masterfrom
satsfy:fix-bitcoind-related-idioms

Conversation

@satsfy
Copy link
Copy Markdown
Contributor

@satsfy satsfy commented May 1, 2026

Follow up from #573 (comment)

Continues corepc-node to bitcoind rename.

This updates stale documentation references that were missed in earlier changes. It fixes the top level crate listing, the bitcoind crate README examples and text, the bitcoind/contrib/extra_tests.sh comments, and the integration_test README.

@satsfy satsfy mentioned this pull request May 1, 2026
Merged
@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from 1379c37 to a5e8d9b Compare May 1, 2026 00:37
@tcharding
Copy link
Copy Markdown
Member

tcharding commented May 1, 2026

Oh extra_test.sh is from the old CI setup, it can be deleted. As can crates.sh.

update-lock-files.sh can go too if the justfile is patched as well but that is kind of unrelated.

@tcharding
Copy link
Copy Markdown
Member

tcharding commented May 1, 2026

I think that is the second time this week I've seen that CI fail. Re-ran it.

@jamillambert jamillambert mentioned this pull request May 1, 2026
Merged
jamillambert
jamillambert reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the label C-bitcoind that the changes in this PR require.

All the docs changes look good. The deletion of extra_tests.sh, crates.sh and update-lock-files.sh and updating the justfile can be done here or a separate PR.

Reviewed a5e8d9b

@satsfy satsfy mentioned this pull request May 1, 2026
Merged
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 1, 2026

Thanks, looked more sensible to open a new PR for it #575

jamillambert
jamillambert reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you swap the commit order, currently you "fix" extra_tests.sh then in the next commit delete it.

@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from e975e37 to 7c3ed79 Compare May 1, 2026 21:05
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 1, 2026 •
edited
Loading

Force push with the mentioned change, my oversight, thanks.

jamillambert
jamillambert reviewed May 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file deletions are better done in #575. Either way they shouldn't be in two PRs.

@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from 7c3ed79 to 0f32d3a Compare May 2, 2026 21:10
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 2, 2026

The file deletions have been isolated in #575.

@tcharding tcharding mentioned this pull request May 4, 2026
Closed
@tcharding
Copy link
Copy Markdown
Member

tcharding commented May 4, 2026

Still one left in electsd readme mate.

@tcharding tcharding mentioned this pull request May 4, 2026
Closed
@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from 0f32d3a to a913ac6 Compare May 4, 2026 14:34
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented May 4, 2026

Still one left in electsd readme mate.

The fix for that was already in master, from a recently merged PR, so it was not included here. Anyways, I rebased, and everything should be fixed.

@satsfy satsfy force-pushed the fix-bitcoind-related-idioms branch from a913ac6 to 7a7bca2 Compare May 4, 2026 14:52
jamillambert
jamillambert approved these changes May 4, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a7bca2

tcharding
tcharding approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a7bca2

@tcharding tcharding merged commit cfb740d into rust-bitcoin:master May 5, 2026
39 checks passed
tcharding added a commit that referenced this pull request May 6, 2026
@tcharding
Merge #575: contrib: remove obsolete scripts and document lock file u…
92c44b3 
…pdates

8d74097 contrib: add rbmt comment to update-lock-files (Renato Britto)
f426e07 contrib: delete contrib scripts no longer in use (satsfy (Renato Britto))

Pull request description:

  Based on #574 (comment)

  Remove contrib scripts that are no longer needed and add clarification to the remaining lock file update script.

  Changes:
  - Delete bitcoind/contrib/extra_tests.sh (version-specific tests now in CI)
  - Delete contrib/crates.sh (no longer used by test scripts)
  - Document why contrib/update-lock-files.sh cannot be replaced by cargo rbmt

  The update-lock-files.sh script requires custom feature configuration for `SPECIFIC_FEATURES_CRATES` (integration_test, bitcoind) that cargo rbmt lock does not support.

ACKs for top commit:
  tcharding:
    ACK 8d74097

Tree-SHA512: 098b31d8a7ddeffa8e97847ed1c842d4880c064023be2902ea35239d81635727185584b36386f9f1422964ca8c9f7904fe02a343dbfdffae6af774f8504c8011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tcharding tcharding tcharding approved these changes

@jamillambert jamillambert jamillambert approved these changes

@RCasatta RCasatta Awaiting requested review from RCasatta RCasatta is a code owner

Assignees

No one assigned

Labels

C-integration-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satsfy @tcharding @jamillambert