13.x: plan: add Plan::tap_sighash_default accessor#952
Open
evanlinjin wants to merge 2 commits into
Open
Conversation
8f4a22b to
4da734a
Compare
2 tasks
4da734a to
022cb02
Compare
Exposes the existing per-Schnorr-placeholder size assumption — recorded when the plan was built from `TaprootCanSign::sighash_default` — as a single `Option<bool>` on the Plan. Returns `Some(true)` when every Schnorr placeholder is sized for a 64-byte signature (SIGHASH_DEFAULT), `Some(false)` when every one is sized for 65 bytes (any non-Default Taproot sighash flag), and `None` for non-Taproot plans or mixed plans that cannot be expressed by a single uniform sighash policy per BIP-174. Callers constructing a PSBT can use this to populate `PSBT_IN_SIGHASH_TYPE` consistently with the witness-size assumption baked into `Plan::satisfaction_weight`.
022cb02 to
304585a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
13.x backport of #951.
Adds a public accessor on
Planthat exposes the existing per-Schnorr-placeholder size assumption — recorded when the plan was built fromTaprootCanSign::sighash_default— as a singleOption<bool>.See #951 for full rationale and the test.
Test plan
cargo build— clean. (No test on this backport; covered on plan: add Plan::tap_sighash_default accessor #951.)🤖 Generated with Claude Code