Skip to content

Test graviola in CI#1631

Merged
bjorn3 merged 1 commit intorust-lang:mainfrom
CathalMullan:graviola-tests
May 5, 2026
Merged

Test graviola in CI#1631
bjorn3 merged 1 commit intorust-lang:mainfrom
CathalMullan:graviola-tests

Conversation

@CathalMullan
Copy link
Copy Markdown
Contributor

@CathalMullan CathalMullan commented Mar 2, 2026

Opening as a draft for now, since none of these jobs will actually pass:

  • x86_64 needs the rustc fix
  • aarch64 needs added intrinsics

valgrind is needed due to crabgrind usage: https://github.com/ctz/graviola/blob/v/0.3.2/graviola/src/low/ct.rs#L5

Could consider patching it out, or making it optional upstream.

@CathalMullan CathalMullan force-pushed the graviola-tests branch 2 times, most recently from fe82b78 to 6b54626 Compare March 6, 2026 20:09
@CathalMullan CathalMullan force-pushed the graviola-tests branch 3 times, most recently from 40ea033 to 914eb80 Compare March 10, 2026 21:38
@CathalMullan
Copy link
Copy Markdown
Contributor Author

Opted to patch out crabgrind to avoid needing valgrind in CI.
Also had to bump AWS-LC to avoid needing cmake.

@CathalMullan CathalMullan marked this pull request as ready for review March 10, 2026 21:40
Comment thread patches/0001-graviola-Disable-crabgrind-and-bump-aws-lc-rs.patch Outdated
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 1, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented May 4, 2026

Would you mind disabling the new tests on Windows? They are the slowest CI jobs.

@CathalMullan
Copy link
Copy Markdown
Contributor Author

Skipping the graviola tests on Windows saved around 3 minutes.
Probably better off splitting the sysroot tests into separate jobs?

@bjorn3 bjorn3 merged commit b2a1b93 into rust-lang:main May 5, 2026
25 checks passed
@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented May 5, 2026

Thanks!

Splitting the sysroot tests into separate jobs would increase the amount of concurrent jobs that are used, which probably slows down the start of them when pushing a couple of commits in relatively quick succession, which I sometimes do.

@CathalMullan CathalMullan deleted the graviola-tests branch May 5, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants