Test graviola in CI#1631
Conversation
fe82b78 to
6b54626
Compare
40ea033 to
914eb80
Compare
|
Opted to patch out crabgrind to avoid needing valgrind in CI. |
914eb80 to
fe90371
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Would you mind disabling the new tests on Windows? They are the slowest CI jobs. |
fe90371 to
e3c6cc0
Compare
|
Skipping the graviola tests on Windows saved around 3 minutes. |
|
Thanks! Splitting the sysroot tests into separate jobs would increase the amount of concurrent jobs that are used, which probably slows down the start of them when pushing a couple of commits in relatively quick succession, which I sometimes do. |
Opening as a draft for now, since none of these jobs will actually pass:
x86_64 needs the rustc fixvalgrind is needed due to crabgrind usage: https://github.com/ctz/graviola/blob/v/0.3.2/graviola/src/low/ct.rs#L5
Could consider patching it out, or making it optional upstream.