Skip to content

Delay bootstrap window until landing dialog clears#928

Open
MhaWay wants to merge 1 commit into
rwmt:devfrom
MhaWay:fix-bootstrap-window-after-landing
Open

Delay bootstrap window until landing dialog clears#928
MhaWay wants to merge 1 commit into
rwmt:devfrom
MhaWay:fix-bootstrap-window-after-landing

Conversation

@MhaWay
Copy link
Copy Markdown
Contributor

@MhaWay MhaWay commented May 19, 2026

Added a guard for the bootstrap window so it does not show up too early while the landing/scenario message is still blocking input.

This keeps the bootstrap flow active, but delays the window until the landing dialog is out of the way.

Copilot AI review requested due to automatic review settings May 19, 2026 19:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Delays showing the BootstrapConfiguratorWindow after map initialization until any open Dialog_MessageBox (e.g., the landing dialog) is dismissed, and retries displaying the window during the post-map-enter tick while still waiting for controllable colonists.

Changes:

  • Extracted window-display logic into a new TryShowBootstrapWindow helper that skips adding the window while a Dialog_MessageBox is on the stack.
  • OnBootstrapMapInitialized now delegates to this helper instead of directly adding the window.
  • TickPostMapEnterSaveDelayAndMaybeSave re-attempts showing the window each tick while waiting for colonists, so it appears once the blocking dialog closes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MhaWay
Copy link
Copy Markdown
Contributor Author

MhaWay commented May 19, 2026

fix, standalone server, 1.6

@notfood notfood added fix Fixes for a bug or desync. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). standalone server Fix or bugs relating to the standalone server. labels May 19, 2026
@notfood notfood moved this to In review in 1.6 and Odyssey May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). fix Fixes for a bug or desync. standalone server Fix or bugs relating to the standalone server.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants