Skip to content

Fix bootstrap world map rotation input#932

Open
MhaWay wants to merge 3 commits into
rwmt:devfrom
MhaWay:fix-bootstrap-world-map-rotation-input
Open

Fix bootstrap world map rotation input#932
MhaWay wants to merge 3 commits into
rwmt:devfrom
MhaWay:fix-bootstrap-world-map-rotation-input

Conversation

@MhaWay
Copy link
Copy Markdown
Contributor

@MhaWay MhaWay commented May 19, 2026

Summary

Fix bootstrap world-map rotation during colony creation.

Changes

  • clear camera-blocking window flags on any already open windows when Create game and upload save starts the vanilla new-colony flow
  • keep the change localized to the bootstrap handoff point instead of patching vanilla world input globally

Validation

  • reproduced the issue in bootstrap flow
  • verified in-game that globe rotation now works during starting-site selection
  • built and deployed the client mod successfully

Copilot AI review requested due to automatic review settings May 19, 2026 23:44
@MhaWay
Copy link
Copy Markdown
Contributor Author

MhaWay commented May 19, 2026

1.6, fix, standalone server

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes blocked globe rotation during the vanilla starting-site selection portion of the bootstrap “create game and upload save” flow by ensuring camera/input-blocking window flags don’t interfere during the handoff.

Changes:

  • Clears absorbInputAroundWindow / preventCameraMotion on currently open windows when starting the vanilla new-colony flow.
  • Adjusts BootstrapConfiguratorWindow window flags across the bootstrap-map-initialization boundary to re-enable expected behavior when the window is shown again.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +137 to +142
foreach (var window in Find.WindowStack.Windows)
{
window.absorbInputAroundWindow = false;
window.preventCameraMotion = false;
}

@notfood notfood added fix Fixes for a bug or desync. 1.6 Fixes or bugs relating to 1.6 (Not Odyssey). standalone server Fix or bugs relating to the standalone server. labels May 20, 2026
@notfood notfood moved this to In review in 1.6 and Odyssey May 20, 2026
@mibac138
Copy link
Copy Markdown
Member

I'm not sure I understand why do you adjust every windows' configuration. As I understand it, this is an issue caused by some MP code, so why doesn't the fix adjust just the (I presume it's this, correct me if I'm wrong) BootstrapWindow?

@MhaWay
Copy link
Copy Markdown
Contributor Author

MhaWay commented May 20, 2026

I'm not sure I understand why do you adjust every windows' configuration. As I understand it, this is an issue caused by some MP code, so why doesn't the fix adjust just the (I presume it's this, correct me if I'm wrong) BootstrapWindow?

Yes is about the bootstrap code but im doing that cuz needed a first fix, i was planning to find the exact point where gives the issue. The page called by harmony, for the settlement selection should use this, but strangely won't fix rhe issue if i call an event from that page to set up the free movement of the camera, then i need to figure out where the block is getting the bug. I'd say rhat this is more a momentary fix, and since it works i started sending this

@mibac138
Copy link
Copy Markdown
Member

Ok, please add a TODO comment with an explanation then

@MhaWay
Copy link
Copy Markdown
Contributor Author

MhaWay commented May 20, 2026

Added a TODO in 66a2fef documenting that this is a temporary workaround.

The current fix clears the active window flags at the bootstrap handoff because the exact MP window/state still keeping WindowStack.WindowsPreventCameraMotion true has not been isolated yet. Once that blocker is identified, this should be narrowed to the specific source instead of touching the full stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.6 Fixes or bugs relating to 1.6 (Not Odyssey). fix Fixes for a bug or desync. standalone server Fix or bugs relating to the standalone server.

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

4 participants