CLDSRV-883: CreateMultipartUpload parse checksum headers and store them in MPU overview object#6144
Open
leif-scality wants to merge 1 commit intodevelopment/9.4from
Open
Conversation
Contributor
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
|
LGTM |
leif-scality
force-pushed
the
improvement/CLDSRV-883-create-mpu-handle-checksum
branch
from
401021f to
21a51aa
Compare
|
LGTM |
Codecov Report❌ Patch coverage is
Additional details and impacted files
@@ Coverage Diff @@
## development/9.4 #6144 +/- ##
===================================================
+ Coverage 84.84% 84.90% +0.05%
===================================================
Files 207 207
Lines 13613 13659 +46
===================================================
+ Hits 11550 11597 +47
+ Misses 2063 2062 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
leif-scality
force-pushed
the
improvement/CLDSRV-883-create-mpu-handle-checksum
branch
from
21a51aa to
68227d0
Compare
|
LGTM |
…em in the MPU overview object
leif-scality
force-pushed
the
improvement/CLDSRV-883-create-mpu-handle-checksum
branch
from
68227d0 to
ba8eaae
Compare
|
LGTM |
anurag4DSB
approved these changes
Apr 13, 2026
| details: { algorithm: 'md4' }, | ||
| }); | ||
| assert.strictEqual(result.message, 'InvalidRequest'); | ||
| assert(result.description.includes('[CRC32, CRC32C, CRC64NVME, SHA1, SHA256]')); |
Contributor
There was a problem hiding this comment.
assert.match might be appropriate here so in case of error we can see the difference between actual value and expected.
Otherwise here with a boolean we'll only see true !== false and have no more details
| details: { type: 'COMPOSITE' }, | ||
| }); | ||
| assert.strictEqual(result.message, 'InvalidRequest'); | ||
| assert(result.description.includes( |
Contributor
There was a problem hiding this comment.
same here, assert.match with regexp can provide more details on failure than boolean
| 'x-amz-checksum-type': 'BADTYPE', | ||
| }, err => { | ||
| assert.strictEqual(err.message, 'InvalidRequest'); | ||
| assert(err.description.includes('algorithm')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.