Skip to content

fix: replace set_over with_extremes #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jokasimr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: replace set_over with_extremes #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/plopp/graphics/colormapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,11 @@ def _get_cmap(colormap: str | Colormap, nan_color: str | None = None) -> Colorma
except (KeyError, ValueError):
# Case where we have just a single color
cmap = LinearSegmentedColormap.from_list('tmp', [colormap, colormap])
cmap.set_over(colormap)
cmap.set_under(colormap)
cmap.set_bad(colormap)
cmap = cmap.with_extremes(
over=colormap,
under=colormap,
bad=colormap,
)
return cmap

# Add under and over values to the cmap
Expand All @@ -68,15 +70,19 @@ def _get_cmap(colormap: str | Colormap, nan_color: str | None = None) -> Colorma
over = cmap.get_over()
under = cmap.get_under()
# Note that we only shift the first 3 RGB values, leaving alpha unchanged.
cmap.set_over(
[_shift_color(c, delta * (-1 + 2 * (np.mean(over) > 0.5))) for c in over[:3]]
cmap = cmap.with_extremes(
over=[
_shift_color(c, delta * (-1 + 2 * (np.mean(over) > 0.5))) for c in over[:3]
],
under=(
[
_shift_color(c, delta * (-1 + 2 * (np.mean(under) > 0.5)))
for c in under[:3]
]
),
)
cmap.set_under(
[_shift_color(c, delta * (-1 + 2 * (np.mean(under) > 0.5))) for c in under[:3]]
)

if nan_color is not None:
cmap.set_bad(color=nan_color)
cmap = cmap.with_extremes(bad=nan_color)
return cmap


Expand Down Expand Up @@ -164,7 +170,7 @@ def __init__(
# (it only applied to non-masked data), so we still need to set the 'bad'
# color here. We choose to set it to the 'over' color for a lack of a
# better idea.
self.mask_cmap.set_bad(self.mask_cmap.get_over())
self.mask_cmap = self.mask_cmap.with_extremes(bad=self.mask_cmap.get_over())

# Inside the autoscale, we need to distinguish between a min value that was set
# by the user and one that was found by looping over all the data.
Expand Down
Loading