Skip to content

Commit d24e1c4

Browse files
robimarkogregkh
authored andcommitted
mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M
commit dbfbddc upstream. It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support does not work when the core is trying to use REQ_OP_WRITE_ZEROES. We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora 301W that we did not previously have and tracked it down to REQ_OP_WRITE_ZEROES: [ 18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags 0x800 phys_seg 0 prio class 2 Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to disable TRIM. Signed-off-by: Robert Marko <robimarko@gmail.com> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20230530213259.1776512-1-robimarko@gmail.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 58f67be commit d24e1c4

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/mmc/core/quirks.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,13 @@ static const struct mmc_fixup mmc_blk_fixups[] = {
9797
MMC_FIXUP("M62704", CID_MANFID_KINGSTON, 0x0100, add_quirk_mmc,
9898
MMC_QUIRK_TRIM_BROKEN),
9999

100+
/*
101+
* Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
102+
* support being used to offload WRITE_ZEROES.
103+
*/
104+
MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
105+
MMC_QUIRK_TRIM_BROKEN),
106+
100107
/*
101108
* On Some Kingston eMMCs, performing trim can result in
102109
* unrecoverable data conrruption occasionally due to a firmware bug.

0 commit comments

Comments
 (0)