Skip to content

For OpImageFetch, do not provide both Lod and Sample operands#4210

Merged
georgemoralis merged 1 commit intoshadps4-emu:mainfrom
mikusp:op_image_fetch_lod
Apr 20, 2026
Merged

For OpImageFetch, do not provide both Lod and Sample operands#4210
georgemoralis merged 1 commit intoshadps4-emu:mainfrom
mikusp:op_image_fetch_lod

Conversation

@mikusp
Copy link
Copy Markdown
Collaborator

@mikusp mikusp commented Apr 2, 2026

An attempt to fix a Vulkan validation error:

[Render.Vulkan] <Error> (shadPS4:GpuComm) vk_platform.cpp:57 DebugUtilsCallback: VUID-VkShaderModuleCreateInfo-pCode-08737: vkCreateShaderModule(): pCreateInfo->pCode (spirv-val produced an error):
Image Operand Lod requires 'MS' parameter to be 0
  %131 = OpImageFetch %f32vec4_id %130 %129 Lod|Sample %u32_id_0 %u32_id_0

@georgemoralis georgemoralis marked this pull request as ready for review April 20, 2026 08:00
@georgemoralis
Copy link
Copy Markdown
Collaborator

georgemoralis commented Apr 20, 2026

turtle agreed

@georgemoralis georgemoralis merged commit ffbcd0d into shadps4-emu:main Apr 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raphaelthegreat raphaelthegreat Awaiting requested review from raphaelthegreat

@squidbus squidbus Awaiting requested review from squidbus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikusp @georgemoralis