TT-7316 Bold workflow shows after adding step#310
Closed
gtryus wants to merge 2 commits into
Closed
Conversation
gtryus
force-pushed
the
TT-7316-bold-wf-ed
branch
from
637facd to
4242789
Compare
gtryus
changed the title
- update sql to fix issues - Add Bold workflow steps and enhance tool settings handling - Enhance OrgHead and StepEditor components with team workflow process integration - Integrated `useTeamWorkflowProcess` into `OrgHead` to manage workflow steps based on the organization context. - Updated `StepEditor` to utilize the new `getProcessTemplateSteps` and `resolveOrgWorkflowStepPresentation` functions for improved step handling and presentation. - Refactored `useOrgWorkflowSteps` to streamline workflow step retrieval and processing. - Improved error handling in `getTool` and `getToolSettings` functions for better resilience against malformed data. - Adjusted `useTeamCreate` to log created workflow steps for better debugging. - Remove console log statements from useOrgWorkflowSteps, useStepTool, and useTeamCreate for cleaner code and improved performance.
gtryus
force-pushed
the
TT-7316-bold-wf-ed
branch
from
4242789 to
2e1b24d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves organization workflow step handling so the Step Editor and workflow creation stay aligned for process-specific workflows (notably BOLD), while also making tool/settings parsing more resilient to malformed or legacy data.
Changes:
- Added process-scoped workflow step resolution utilities (
getProcessTemplateSteps,resolveOrgWorkflowStepPresentation) and improved deterministic sorting/normalization inuseOrgWorkflowSteps. - Updated
StepEditorto load steps for the selected process and to correct step presentation when org step data is mis-sequenced or duplicated. - Hardened
getTool/getToolSettingsagainst invalid JSON and legacy settings formats, and added Cypress coverage for BOLD step rendering + legacy settings.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/crud/useStepTool.ts | Adds try/catch around tool JSON parsing and normalizes legacy settings values to a JSON string. |
| src/renderer/src/crud/useOrgWorkflowSteps.tsx | Introduces template-step retrieval and presentation resolution helpers; improves sort stability and normalizes sequence numbers when creating org steps. |
| src/renderer/src/components/StepEditor/StepEditor.tsx | Loads org workflow steps scoped to the current process and uses the new resolution helpers to display correct names/tools/ordering. |
| src/renderer/src/components/StepEditor/StepEditor.cy.tsx | Adds Cypress component tests validating BOLD step loading and legacy embedded-object settings handling. |
| src/renderer/src/components/App/OrgHead.tsx | Uses useTeamWorkflowProcess so “Edit Workflow” opens the Step Editor for the team’s actual workflow process (fallback to default). |
| migration/bold-workflow/insert-bold-workflowsteps.sql | Updates the BOLD workflow seed to use jsonb values and the expected nested-settings string format. |
| .vscode/mcp.json | Adds additional MCP servers (chrome-devtools, playwright) to workspace MCP config. |
sarahentzel
reviewed
May 15, 2026
| // Scope to the team's workflow when `process` is set (e.g. bold). Using | ||
| // 'ANY' merged every process and sorted only by sequencenum, so Edit Workflow | ||
| // could disagree with the steps CreateOrgWorkflowSteps just added. | ||
| GetOrgWorkflowSteps({ |
Collaborator
There was a problem hiding this comment.
If a team has mixed process workflow steps, I think we want to see them all. Why do your bold teams have mixed workflow steps. I think this is an unnecessary and dangerous change. We send in the defaultworkflow, so there will always be a process, and 'ANY' will never be used. THere are 171 teams on prod with mixed processes. Will only steps from draft show up for them?
Collaborator
There was a problem hiding this comment.
I think "merged every process and sorted only by sequencenum" is exactly what we want to be doing, even if AI doesn't understand it.
Contributor
Author
|
This logic would not work because it mis-diagnosed the root cause of the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useTeamWorkflowProcessintoOrgHeadto manage workflow steps based on the organization context.StepEditorto utilize the newgetProcessTemplateStepsandresolveOrgWorkflowStepPresentationfunctions for improved step handling and presentation.useOrgWorkflowStepsto streamline workflow step retrieval and processing.getToolandgetToolSettingsfunctions for better resilience against malformed data.useTeamCreateto log created workflow steps for better debugging.These changes enhance the workflow management capabilities and improve the overall robustness of the application.