TT-7340 Add tip for workflow settings and BOLD Record#315
Open
gtryus wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new localized string used by the Step Editor to display a more descriptive workflow settings label (e.g., “Settings for [tool] of [artifact type]”), and updates the localization bundle references and English translation sources accordingly.
Changes:
- Add
stepEditor.settingsForto the localization store/types and English XLF/XLIFF sources. - Update
StepEditor.prettySettings()to use the new “Settings for {0} of {1}” format for Record/Transcribe/Paratext settings. - Update the exported localization bundle pointer (
exported-strings-name.json) to a new generated strings JSON.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/src/store/localization/reducers.tsx | Adds default stepEditor.settingsFor string in initial localization state. |
| src/renderer/src/store/localization/model.tsx | Extends IStepEditorStrings to include settingsFor. |
| src/renderer/src/store/localization/exported-strings-name.json | Points runtime localization loading to the newly generated strings bundle. |
| src/renderer/src/components/StepEditor/StepEditor.tsx | Uses the new settingsFor format when rendering settings titles for supported tools. |
| localization/TranscriberAdmin-en.xlf | Adds the new string to the English translation source file. |
| localization/TranscriberAdmin-en-1.2.xliff | Adds the new string to the English XLIFF source file with source context. |
- Introduced `isBoldWorkflow` context state to manage BOLD workflow logic. - Updated `MediaRecord`, `WSAudioPlayer`, and `PassageDetail` components to conditionally render elements based on the BOLD workflow state. - Modified `MobileStepComplete` and `PassageDetailMobileFooter` to hide step completion UI in BOLD workflow. - Enhanced `RecordButton` to handle recording logic specific to BOLD workflow. - Added tests to verify BOLD workflow behavior in mobile components.
gtryus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.