Skip to content

Add sync benchmarks#2276

Open
myieye wants to merge 11 commits into
developfrom
sync-perf-benchmarks
Open

Add sync benchmarks#2276
myieye wants to merge 11 commits into
developfrom
sync-perf-benchmarks

Conversation

@myieye
Copy link
Copy Markdown
Collaborator

@myieye myieye commented May 19, 2026

Reopening of #2254
(I used the "Sync" button in VS Code and that resulted in the old PR getting merged into develop...oops.
So, I force pushed to develop to clean it up.)

Adds various sync benchmark tests.
The motivation for this is that I was exploring performance optimizations and having a benchmark in place lets me/us actually measure those optimizations.
This PR includes the first and smallest optimization: a DB index on the commit order columns.
So, now there are 2 Comment lines per benchmark documenting the approximate speedup that the index resulted in.

Hopefully future PRs will add more radical speedups.

myieye added 10 commits May 18, 2026 17:46
Monitoring strategy with WarmupCount=1, IterationCount=4 — same total
work as before, but iteration 1's JIT/EF-model-build/cold-cache cost is
discarded instead of folded into the measurement, so StdDev tightens and
thresholds can come down to genuine 3σ above the with-index mean.

Both comment lines (baseline + with-index) are re-measured under this
config so the speedup comparison is apples-to-apples.
@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label May 19, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Review Change Stack

Warning

Rate limit exceeded

@myieye has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 55 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d3955426-2744-4eea-bd15-a6201e6a42d5

📥 Commits

Reviewing files that changed from the base of the PR and between 52ae636 and e1a5eac.

📒 Files selected for processing (11)
  • .github/workflows/fw-lite.yaml
  • backend/Directory.Packages.props
  • backend/FwLite/FwLiteProjectSync.Tests/BenchmarkSupport.cs
  • backend/FwLite/FwLiteProjectSync.Tests/Fixtures/Sena3Collection.cs
  • backend/FwLite/FwLiteProjectSync.Tests/FwLiteProjectSync.Tests.csproj
  • backend/FwLite/FwLiteProjectSync.Tests/Sena3SyncTests.cs
  • backend/FwLite/FwLiteProjectSync.Tests/SyncBenchmark.cs
  • backend/FwLite/FwLiteProjectSync.Tests/SyncMutationBenchmark.cs
  • backend/FwLite/FwLiteProjectSync.Tests/XUnitBenchmarkLogger.cs
  • backend/FwLite/LcmCrdt/Migrations/20260506150734_AddCommitsOrderIndex.Designer.cs
  • backend/FwLite/LcmCrdt/Migrations/20260506150734_AddCommitsOrderIndex.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync-perf-benchmarks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@argos-ci
Copy link
Copy Markdown

argos-ci Bot commented May 19, 2026

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - May 19, 2026, 12:05 PM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

UI unit Tests

  1 files  ±0   59 suites  ±0   26s ⏱️ -5s
176 tests ±0  176 ✅ ±0  0 💤 ±0  0 ❌ ±0 
245 runs  ±0  245 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e1a5eac. ± Comparison against base commit 52ae636.

♻️ This comment has been updated with latest results.

BenchmarkDotNet has supported async benchmark methods for a long time —
the old comment claiming otherwise was wrong, and the .Result blocking
call was unnecessary. IterationSetup stays sync (async support there
needs BDN 0.16+).
@myieye myieye force-pushed the sync-perf-benchmarks branch from 61ea495 to e1a5eac Compare May 19, 2026 12:02
@github-actions
Copy link
Copy Markdown
Contributor

C# Unit Tests

165 tests  ±0   165 ✅ ±0   20s ⏱️ ±0s
 23 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e1a5eac. ± Comparison against base commit 52ae636.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant